From 7f58182b047319b41814cb642defe4ad89aecf6f Mon Sep 17 00:00:00 2001
From: grisel-davy <grisel-davy@re2o-server.crans.org>
Date: Tue, 20 Mar 2018 17:28:31 +0100
Subject: [PATCH 01/26] Le bouton est maintenant en vert, moins confusant.

---
 templates/registration/login.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/templates/registration/login.html b/templates/registration/login.html
index 7b986d3b..6522a6b6 100644
--- a/templates/registration/login.html
+++ b/templates/registration/login.html
@@ -45,7 +45,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 <p><form method="post" action="{% url 'login' %}">
     {% csrf_token %}
     {% bootstrap_form form %}
-    {% bootstrap_button "Login" button_type="submit" icon="log-in" %}
+    <button class="btn btn-success" type="submit"><span class="glyphicon glyphicon-log-in"></span> Login</button>
     <input type="hidden" name="next" value="{{ next }}" />
 </form></p>
 <p><a class="btn btn-warning btn-sm" role="button" href="{% url 'users:reset-password' %}"> Mot de passe oublié ?</a></p>

From 06ecd44d0292e40a1ab8d6bb320bec3a86b7d7c2 Mon Sep 17 00:00:00 2001
From: Krokmou <krokmou@crans.org>
Date: Thu, 22 Mar 2018 19:21:49 +0100
Subject: [PATCH 02/26] chsh affiche le shell actuel

---
 users/management/commands/chsh.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/users/management/commands/chsh.py b/users/management/commands/chsh.py
index bcfec3a8..df4d6c0d 100755
--- a/users/management/commands/chsh.py
+++ b/users/management/commands/chsh.py
@@ -54,7 +54,11 @@ class Command(BaseCommand):
             raise CommandError(msg)
 
         shells = ListShell.objects.all()
-        self.stdout.write("Choisissez un shell pour l'utilisateur %s :" % target_user.pseudo)
+
+        current_shell = "inconnu"
+        if target_user.shell:
+            current_shell = target_user.shell.get_pretty_name()
+        self.stdout.write("Choisissez un shell pour l'utilisateur %s (le shell actuel est %s) :" % (target_user.pseudo, current_shell))
         for shell in shells:
             self.stdout.write("%d - %s (%s)" % (shell.id, shell.get_pretty_name(), shell.shell))
         shell_id = input("Entrez un nombre : ")

From 8cab7e90aa33e57099a5fa4db732d0620d4e61f6 Mon Sep 17 00:00:00 2001
From: grisel-davy <grisel-davy@re2o-server.crans.org>
Date: Fri, 23 Mar 2018 15:06:12 +0100
Subject: [PATCH 03/26] ajout de div pour rendre les tables scrollables
 horizontalement

---
 cotisations/templates/cotisations/aff_cotisations.html | 4 ++--
 machines/templates/machines/aff_machines.html          | 5 ++++-
 users/templates/users/aff_users.html                   | 3 ++-
 3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/cotisations/templates/cotisations/aff_cotisations.html b/cotisations/templates/cotisations/aff_cotisations.html
index b73bc107..48a856a2 100644
--- a/cotisations/templates/cotisations/aff_cotisations.html
+++ b/cotisations/templates/cotisations/aff_cotisations.html
@@ -23,7 +23,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 {% endcomment %}
 
 {% load acl %}
-
+<div class="table-responsive">
 {% if facture_list.paginator %}
 {% include "pagination.html" with list=facture_list %}
 {% endif %}
@@ -85,4 +85,4 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 {% if facture_list.paginator %}
 {% include "pagination.html" with list=facture_list %}
 {% endif %}
-
+</div>
diff --git a/machines/templates/machines/aff_machines.html b/machines/templates/machines/aff_machines.html
index c286fcd6..f6da4165 100644
--- a/machines/templates/machines/aff_machines.html
+++ b/machines/templates/machines/aff_machines.html
@@ -23,11 +23,12 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 {% endcomment %}
 
 {% load acl %}
-
+<div class="table-responsive">
 {% if machines_list.paginator %}
 {% include "pagination.html" with list=machines_list %}
 {% endif %}
 
+
 <table class="table" id="machines_table">
     <colgroup>
         <col>
@@ -175,6 +176,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
     </tbody>
 </table>
 
+
 <script>
 $("#machines_table").ready( function() {
     var alias_div = [{% for machine in machines_list %}{% for interface in machine.interface_set.all %}{% if interface.domain.related_domain.all %}$("#collapseDomain_{{interface.id}}"), {% endif %}{% endfor %}{% endfor %}];
@@ -193,3 +195,4 @@ $("#machines_table").ready( function() {
 {% if machines_list.paginator %}
 {% include "pagination.html" with list=machines_list %}
 {% endif %}
+</div>
diff --git a/users/templates/users/aff_users.html b/users/templates/users/aff_users.html
index 199b2f17..d8c18890 100644
--- a/users/templates/users/aff_users.html
+++ b/users/templates/users/aff_users.html
@@ -21,7 +21,7 @@ You should have received a copy of the GNU General Public License along
 with this program; if not, write to the Free Software Foundation, Inc.,
 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 {% endcomment %}
-
+<div class="table-responsive">
 {% if users_list.paginator %}
 {% include "pagination.html" with list=users_list %}
 {% endif %}
@@ -60,3 +60,4 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 {% if users_list.paginator %}
 {% include "pagination.html" with list=users_list %}
 {% endif %}
+</div>

From 9a7e9ebfff071399fe9f268388ec24f3b05291dd Mon Sep 17 00:00:00 2001
From: grisel-davy <grisel-davy@re2o-server.crans.org>
Date: Fri, 23 Mar 2018 15:31:18 +0100
Subject: [PATCH 04/26] image cliquable

---
 re2o/templates/re2o/index.html | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/re2o/templates/re2o/index.html b/re2o/templates/re2o/index.html
index 877faf10..25eec921 100644
--- a/re2o/templates/re2o/index.html
+++ b/re2o/templates/re2o/index.html
@@ -37,8 +37,8 @@ with this program; if not, write to the Free Software Foundation, Inc.,
         {% for service in service_list %}
         <div class="col-12">
             <div class="thumbnail">
-                <img src="{% static service.image  %}" alt="{{ service.name }}">
-                <div class="caption">
+                    <a href="{{ service.url }}"><img src="{% static service.image  %}" alt="{{ service.name }}"></a>
+                    <div class="caption">
                     <h3>{{ service.name }}</h3>
                     <p>{{ service.description }}</p>
                     <p><a href="{{ service.url }}" class="btn btn-primary" role="button">Accéder</a></p>

From 4cd7066fa0056329bb8d0e3f806f40bcfb4b4187 Mon Sep 17 00:00:00 2001
From: Gabriel Detraz <detraz@crans.org>
Date: Sat, 24 Mar 2018 00:50:11 +0100
Subject: [PATCH 05/26] Object bornes specifique

---
 re2o/utils.py                                 |   5 +
 re2o/views.py                                 |   1 +
 topologie/admin.py                            |  16 +-
 topologie/forms.py                            |  26 +++-
 .../management/commands/sync_unifi_ap.py      |  41 +++++
 topologie/migrations/0034_borne.py            |  28 ++++
 .../migrations/0035_auto_20180324_0023.py     |  20 +++
 topologie/models.py                           |  49 ++++++
 topologie/templates/topologie/aff_borne.html  |  74 +++++++++
 topologie/templates/topologie/borne.html      |  63 ++++++++
 .../templates/topologie/index_borne.html      |  41 +++++
 topologie/templates/topologie/sidebar.html    |  10 +-
 topologie/urls.py                             |   7 +-
 topologie/views.py                            | 147 +++++++++++++++++-
 14 files changed, 520 insertions(+), 8 deletions(-)
 create mode 100644 topologie/management/commands/sync_unifi_ap.py
 create mode 100644 topologie/migrations/0034_borne.py
 create mode 100644 topologie/migrations/0035_auto_20180324_0023.py
 create mode 100644 topologie/templates/topologie/aff_borne.html
 create mode 100644 topologie/templates/topologie/borne.html
 create mode 100644 topologie/templates/topologie/index_borne.html

diff --git a/re2o/utils.py b/re2o/utils.py
index 5abe0c33..a3de2a89 100644
--- a/re2o/utils.py
+++ b/re2o/utils.py
@@ -233,6 +233,11 @@ class SortTable:
         'room_name': ['name'],
         'default': ['name']
     }
+    TOPOLOGIE_INDEX_BORNE = {
+        'borne_name': ['domain__name'],
+        'borne_ipv4': ['borne__ipv4__ipv4'],
+        'default': ['domain__name']
+    }
     TOPOLOGIE_INDEX_STACK = {
         'stack_name': ['name'],
         'stack_id': ['stack_id'],
diff --git a/re2o/views.py b/re2o/views.py
index bfb2e6c5..2beb1636 100644
--- a/re2o/views.py
+++ b/re2o/views.py
@@ -82,6 +82,7 @@ HISTORY_BIND = {
         'stack' : topologie.models.Stack,
         'model_switch' : topologie.models.ModelSwitch,
         'constructor_switch' : topologie.models.ConstructorSwitch,
+        'borne' : topologie.models.Borne,
     },
     'machines' : {
         'machine' : machines.models.Machine,
diff --git a/topologie/admin.py b/topologie/admin.py
index a4591222..f7021148 100644
--- a/topologie/admin.py
+++ b/topologie/admin.py
@@ -29,7 +29,15 @@ from __future__ import unicode_literals
 from django.contrib import admin
 from reversion.admin import VersionAdmin
 
-from .models import Port, Room, Switch, Stack, ModelSwitch, ConstructorSwitch
+from .models import (
+    Port,
+    Room,
+    Switch,
+    Stack,
+    ModelSwitch,
+    ConstructorSwitch,
+    Borne
+)
 
 
 class StackAdmin(VersionAdmin):
@@ -47,6 +55,11 @@ class PortAdmin(VersionAdmin):
     pass
 
 
+class BorneAdmin(VersionAdmin):
+    """Administration d'une borne"""
+    pass
+
+
 class RoomAdmin(VersionAdmin):
     """Administration d'un chambre"""
     pass
@@ -63,6 +76,7 @@ class ConstructorSwitchAdmin(VersionAdmin):
 
 
 admin.site.register(Port, PortAdmin)
+admin.site.register(Borne, BorneAdmin)
 admin.site.register(Room, RoomAdmin)
 admin.site.register(Switch, SwitchAdmin)
 admin.site.register(Stack, StackAdmin)
diff --git a/topologie/forms.py b/topologie/forms.py
index c4c369a6..42572fe7 100644
--- a/topologie/forms.py
+++ b/topologie/forms.py
@@ -33,9 +33,18 @@ NewSwitchForm)
 from __future__ import unicode_literals
 
 from machines.models import Interface
+from machines.forms import EditInterfaceForm
 from django import forms
 from django.forms import ModelForm, Form
-from .models import Port, Switch, Room, Stack, ModelSwitch, ConstructorSwitch
+from .models import ( 
+    Port,
+    Switch,
+    Room,
+    Stack,
+    ModelSwitch,
+    ConstructorSwitch,
+    Borne
+)
 
 
 class PortForm(ModelForm):
@@ -102,6 +111,21 @@ class StackForm(ModelForm):
         super(StackForm, self).__init__(*args, prefix=prefix, **kwargs)
 
 
+class AddBorneForm(EditInterfaceForm):
+    """Formulaire pour la création d'une borne
+    Relié directement au modèle borne"""
+    class Meta:
+        model = Borne
+        fields = ['mac_address', 'type', 'ipv4', 'details', 'location']
+
+
+class EditBorneForm(EditInterfaceForm):
+    """Edition d'une interface. Edition complète"""
+    class Meta:
+        model = Borne
+        fields = ['machine', 'type', 'ipv4', 'mac_address', 'details', 'location']
+
+
 class EditSwitchForm(ModelForm):
     """Permet d'éditer un switch : nom et nombre de ports"""
     class Meta:
diff --git a/topologie/management/commands/sync_unifi_ap.py b/topologie/management/commands/sync_unifi_ap.py
new file mode 100644
index 00000000..532aa5d5
--- /dev/null
+++ b/topologie/management/commands/sync_unifi_ap.py
@@ -0,0 +1,41 @@
+# ⁻*- mode: python; coding: utf-8 -*-
+# Re2o est un logiciel d'administration développé initiallement au rezometz. Il
+# se veut agnostique au réseau considéré, de manière à être installable en
+# quelques clics.
+#
+# Copyright © 2018  Gabriel Detraz
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with this program; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+
+from django.core.management.base import BaseCommand, CommandError
+from pymongo import MongoClient
+
+class Command(BaseCommand):
+    help = 'Ce script donne un nom aux bornes dans le controleur unifi.
+    A lancer sur le serveur en local où se trouve le controleur'
+
+    def handle(self, *args, **options):
+        # Connexion mongodb
+        client = MongoClient("mongodb://localhost:27117")
+        db = client.ace
+        device = db['device']
+
+    def set_bornes_names(liste_bornes):
+        """Met à jour les noms des bornes dans la bdd du controleur"""
+        for borne in liste_bornes:
+            device.find_one_and_update({'ip': str(borne['ipHostNumber'][0])}, {'$set': {'name': borne['host'][0].split('.')[0]}})
+        return
+
+        self.stdout.write(self.style.SUCCESS('Mise à jour de la base de donnée unifi avec succès'))
diff --git a/topologie/migrations/0034_borne.py b/topologie/migrations/0034_borne.py
new file mode 100644
index 00000000..6d827f3a
--- /dev/null
+++ b/topologie/migrations/0034_borne.py
@@ -0,0 +1,28 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.7 on 2018-03-23 01:18
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('machines', '0076_auto_20180130_1623'),
+        ('topologie', '0033_auto_20171231_1743'),
+    ]
+
+    operations = [
+        migrations.CreateModel(
+            name='Borne',
+            fields=[
+                ('interface_ptr', models.OneToOneField(auto_created=True, on_delete=django.db.models.deletion.CASCADE, parent_link=True, primary_key=True, serialize=False, to='machines.Interface')),
+                ('location', models.CharField(help_text="Détails sur la localisation de l'AP", max_length=255)),
+            ],
+            options={
+                'permissions': (('view_borne', 'Peut voir une borne'),),
+            },
+            bases=('machines.interface',),
+        ),
+    ]
diff --git a/topologie/migrations/0035_auto_20180324_0023.py b/topologie/migrations/0035_auto_20180324_0023.py
new file mode 100644
index 00000000..7fa69d01
--- /dev/null
+++ b/topologie/migrations/0035_auto_20180324_0023.py
@@ -0,0 +1,20 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.7 on 2018-03-23 23:23
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('topologie', '0034_borne'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='borne',
+            name='location',
+            field=models.CharField(blank=True, help_text="Détails sur la localisation de l'AP", max_length=255, null=True),
+        ),
+    ]
diff --git a/topologie/models.py b/topologie/models.py
index 0871b402..5c48773f 100644
--- a/topologie/models.py
+++ b/topologie/models.py
@@ -47,6 +47,7 @@ from django.db import IntegrityError
 from django.db import transaction
 from reversion import revisions as reversion
 
+from machines.models import Interface
 
 class Stack(models.Model):
     """Un objet stack. Regrouppe des switchs en foreign key
@@ -108,6 +109,53 @@ class Stack(models.Model):
                 inférieure à l'id minimale"})
 
 
+class Borne(Interface):
+    """Define a wireless AP. Inherit from machines.interfaces
+    
+    Definition pour une borne wifi , hérite de machines.interfaces
+    """
+    PRETTY_NAME = "Borne WiFi"
+
+    location = models.CharField(    
+        max_length=255,
+        help_text="Détails sur la localisation de l'AP",
+        blank=True,
+        null=True
+    )
+
+    class Meta:
+        permissions = (
+            ("view_borne", "Peut voir une borne"),
+        )
+
+    def get_instance(borne_id, *args, **kwargs):
+        return Borne.objects.get(pk=borne_id)
+
+    def can_create(user_request, *args, **kwargs):
+        return user_request.has_perm('topologie.add_borne') , u"Vous n'avez pas le droit\
+            de créer une borne"
+
+    def can_edit(self, user_request, *args, **kwargs):
+        if not user_request.has_perm('topologie.change_borne'):
+            return False, u"Vous n'avez pas le droit d'éditer des bornes"
+        return True, None
+
+    def can_delete(self, user_request, *args, **kwargs):
+        if not user_request.has_perm('topologie.delete_borne'):
+            return False, u"Vous n'avez pas le droit de supprimer une borne"
+        return True, None
+
+    def can_view_all(user_request, *args, **kwargs):
+        if not user_request.has_perm('topologie.view_borne'):
+            return False, u"Vous n'avez pas le droit de voir les bornes"
+        return True, None
+
+    def can_view(self, user_request, *args, **kwargs):
+        if not user_request.has_perm('topologie.view_borne'):
+            return False, u"Vous n'avez pas le droit de voir les bornes"
+        return True, None
+
+
 class Switch(models.Model):
     """ Definition d'un switch. Contient un nombre de ports (number),
     un emplacement (location), un stack parent (optionnel, stack)
@@ -192,6 +240,7 @@ class Switch(models.Model):
             else:
                 raise ValidationError({'stack_member_id': "L'id dans la stack\
                     ne peut être nul"})
+
     def create_ports(self, begin, end):
         """ Crée les ports de begin à end si les valeurs données sont cohérentes. """
 
diff --git a/topologie/templates/topologie/aff_borne.html b/topologie/templates/topologie/aff_borne.html
new file mode 100644
index 00000000..8080aaaf
--- /dev/null
+++ b/topologie/templates/topologie/aff_borne.html
@@ -0,0 +1,74 @@
+{% comment %}
+Re2o est un logiciel d'administration développé initiallement au rezometz. Il
+se veut agnostique au réseau considéré, de manière à être installable en
+quelques clics.
+
+Copyright © 2017  Gabriel Détraz
+Copyright © 2017  Goulven Kermarec
+Copyright © 2017  Augustin Lemesle
+
+This program is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 2 of the License, or
+(at your option) any later version.
+
+This program is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License along
+with this program; if not, write to the Free Software Foundation, Inc.,
+51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+{% endcomment %}
+
+{% load acl %}
+
+<div class="table-responsive">
+{% if borne_list.paginator %}
+{% include "pagination.html" with list=borne_list %}
+{% endif %}
+
+
+<table class="table table-striped">
+    <thead>
+        <tr>
+            <th>{% include "buttons/sort.html" with prefix='borne' col='name' text='Borne' %}</th>
+	    <th>{% include "buttons/sort.html" with prefix='borne' col='mac' text='Addresse mac' %}</th>
+	    <th>{% include "buttons/sort.html" with prefix='borne' col='ip' text='Ipv4' %}</th>
+	    <th>Commentaire</th>
+            <th>Localisation</th> 
+	    <th></th>
+        </tr>
+   </thead>
+   {% for borne in borne_list %}
+   <tr>
+       <td>{{borne}}</td>
+       <td>{{borne.mac_address}}</td>
+       <td>{{borne.ipv4}}</td>
+       <td>{{borne.details}}</td>
+       <td>{{borne.location}}</td>
+        <td class="text-right">
+            <a class="btn btn-info btn-sm" role="button" title="Historique" href="{% url 'topologie:history' 'borne' borne.pk %}">
+                <i class="fa fa-history"></i>
+            </a>
+        {% can_edit borne %}
+            <a class="btn btn-primary btn-sm" role="button" title="Éditer" href="{% url 'topologie:edit-borne' borne.id %}">
+                <i class="fa fa-edit"></i>
+            </a>
+	{% acl_end %}
+	{% can_delete borne %}
+            <a class="btn btn-danger btn-sm" role="button" title="Supprimer" href="{% url 'machines:del-interface' borne.id %}">
+                <i class="fa fa-trash"></i>
+            </a>
+        {% acl_end %}
+        </td>
+   </tr>
+   {% endfor %}
+</table>
+
+
+{% if borne_list.paginator %}
+{% include "pagination.html" with list=borne_list %}
+{% endif %}
+</div>
diff --git a/topologie/templates/topologie/borne.html b/topologie/templates/topologie/borne.html
new file mode 100644
index 00000000..57e015d5
--- /dev/null
+++ b/topologie/templates/topologie/borne.html
@@ -0,0 +1,63 @@
+{% extends "topologie/sidebar.html" %}
+{% comment %}
+Re2o est un logiciel d'administration développé initiallement au rezometz. Il
+se veut agnostique au réseau considéré, de manière à être installable en
+quelques clics.
+
+Copyright © 2017  Gabriel Détraz
+Copyright © 2017  Goulven Kermarec
+Copyright © 2017  Augustin Lemesle
+
+This program is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 2 of the License, or
+(at your option) any later version.
+
+This program is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License along
+with this program; if not, write to the Free Software Foundation, Inc.,
+51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+{% endcomment %}
+
+{% load bootstrap3 %}
+{% load massive_bootstrap_form %}
+
+{% block title %}Création et modification d'une borne{% endblock %}
+
+{% block content %}
+{% if topoform %}
+{% bootstrap_form_errors topoform %}
+{% endif %}
+{% if machineform %}
+{% bootstrap_form_errors machineform %}
+{% endif %}
+{% if domainform %}
+{% bootstrap_form_errors domainform %}
+{% endif %}
+
+
+
+<form class="form" method="post">
+    {% csrf_token %}
+    {% if topoform %}
+    <h3>Réglage spécifiques de la borne</h3>
+    {% massive_bootstrap_form topoform 'ipv4,machine' mbf_param=i_mbf_param%}
+    {% endif %}
+    {% if machineform %}
+    <h3>Réglages généraux de la machine associée à la borne</h3>
+    {% massive_bootstrap_form machineform 'user' %}
+    {% endif %}
+    {% if domainform %}
+    <h3>Nom de la machine</h3>
+    {% bootstrap_form domainform %}
+    {% endif %}
+    {% bootstrap_button "Créer ou modifier" button_type="submit" icon="ok" %}
+</form>
+  <br />
+  <br />
+  <br />
+{% endblock %}
diff --git a/topologie/templates/topologie/index_borne.html b/topologie/templates/topologie/index_borne.html
new file mode 100644
index 00000000..e6d20dfb
--- /dev/null
+++ b/topologie/templates/topologie/index_borne.html
@@ -0,0 +1,41 @@
+{% extends "topologie/sidebar.html" %}
+{% comment %}
+Re2o est un logiciel d'administration développé initiallement au rezometz. Il
+se veut agnostique au réseau considéré, de manière à être installable en
+quelques clics.
+
+Copyright © 2017  Gabriel Détraz
+Copyright © 2017  Goulven Kermarec
+Copyright © 2017  Augustin Lemesle
+
+This program is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 2 of the License, or
+(at your option) any later version.
+
+This program is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License along
+with this program; if not, write to the Free Software Foundation, Inc.,
+51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+{% endcomment %}
+
+{% load bootstrap3 %}
+{% load acl %}
+
+{% block title %}Bornes WiFi{% endblock %}
+
+{% block content %}
+  <h2>Points d'accès WiFi</h2>
+{% can_create Room %}
+<a class="btn btn-primary btn-sm" role="button" href="{% url 'topologie:new-borne' %}"><i class="fa fa-plus"></i> Ajouter une borne</a>
+<hr>
+{% acl_end %}
+    {% include "topologie/aff_borne.html" with borne_list=borne_list %}
+    <br />
+    <br />
+    <br />
+{% endblock %}
diff --git a/topologie/templates/topologie/sidebar.html b/topologie/templates/topologie/sidebar.html
index 826169f2..6351ffd0 100644
--- a/topologie/templates/topologie/sidebar.html
+++ b/topologie/templates/topologie/sidebar.html
@@ -26,12 +26,16 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 
 {% block sidebar %}
     <a class="list-group-item list-group-item-info" href="{% url "topologie:index-room" %}">
-        <i class="fa fa-list-ul"></i>
-        Chambres
+        <i class="fa fa-home"></i>
+        Chambres et locaux
     </a>
      <a class="list-group-item list-group-item-info" href="{% url "topologie:index" %}">
-        <i class="fa fa-list-ul"></i>
+        <i class="fa fa-microchip"></i>
         Switchs
+    </a>
+     <a class="list-group-item list-group-item-info" href="{% url "topologie:index-borne" %}">
+        <i class="fa fa-wifi"></i>
+        Bornes WiFi
     </a>
     <a class="list-group-item list-group-item-info" href="{% url "topologie:index-stack" %}">
         <i class="fa fa-list-ul"></i>
diff --git a/topologie/urls.py b/topologie/urls.py
index 3caf22c5..19b87947 100644
--- a/topologie/urls.py
+++ b/topologie/urls.py
@@ -35,7 +35,11 @@ from . import views
 
 urlpatterns = [
     url(r'^$', views.index, name='index'),
-    url(r'^new_switch/$', views.new_switch, name='new-switch'),
+    url(r'^index_borne/$', views.index_borne, name='index-borne'),
+    url(r'^new_borne/$', views.new_borne, name='new-borne'),
+    url(r'^edit_borne/(?P<borne_id>[0-9]+)$',
+        views.edit_borne,
+        name='edit-borne'),
     url(r'^create_ports/(?P<switch_id>[0-9]+)$',
         views.create_ports,
         name='create-ports'),
@@ -43,6 +47,7 @@ urlpatterns = [
     url(r'^new_room/$', views.new_room, name='new-room'),
     url(r'^edit_room/(?P<room_id>[0-9]+)$', views.edit_room, name='edit-room'),
     url(r'^del_room/(?P<room_id>[0-9]+)$', views.del_room, name='del-room'),
+    url(r'^new_switch/$', views.new_switch, name='new-switch'),
     url(r'^switch/(?P<switch_id>[0-9]+)$',
         views.index_port,
         name='index-port'),
diff --git a/topologie/views.py b/topologie/views.py
index f8bc210b..4c50acf5 100644
--- a/topologie/views.py
+++ b/topologie/views.py
@@ -53,7 +53,8 @@ from topologie.models import (
     Room,
     Stack,
     ModelSwitch,
-    ConstructorSwitch
+    ConstructorSwitch,
+    Borne
 )
 from topologie.forms import EditPortForm, NewSwitchForm, EditSwitchForm
 from topologie.forms import (
@@ -62,7 +63,9 @@ from topologie.forms import (
     StackForm,
     EditModelSwitchForm,
     EditConstructorSwitchForm,
-    CreatePortsForm
+    CreatePortsForm,
+    AddBorneForm,
+    EditBorneForm
 )
 from users.views import form
 from re2o.utils import SortTable
@@ -168,6 +171,33 @@ def index_room(request):
         })
 
 
+@login_required
+@can_view_all(Borne)
+def index_borne(request):
+    """ Affichage de l'ensemble des bornes"""
+    borne_list = Borne.objects
+    borne_list = SortTable.sort(
+        borne_list,
+        request.GET.get('col'),
+        request.GET.get('order'),
+        SortTable.TOPOLOGIE_INDEX_BORNE
+    )
+    pagination_number = GeneralOption.get_cached_value('pagination_number')
+    paginator = Paginator(borne_list, pagination_number)
+    page = request.GET.get('page')
+    try:
+        borne_list = paginator.page(page)
+    except PageNotAnInteger:
+        # If page is not an integer, deliver first page.
+        borne_list = paginator.page(1)
+    except EmptyPage:
+        # If page is out of range (e.g. 9999), deliver last page of results.
+        borne_list = paginator.page(paginator.num_pages)
+    return render(request, 'topologie/index_borne.html', {
+        'borne_list': borne_list
+        })
+
+
 @login_required
 @can_view_all(Stack)
 def index_stack(request):
@@ -510,6 +540,119 @@ def edit_switch(request, switch, switch_id):
         }, 'topologie/switch.html', request)
 
 
+@login_required
+@can_create(Borne)
+def new_borne(request):
+    """ Creation d'une borne. Cree en meme temps l'interface et la machine
+    associée. Vue complexe. Appelle successivement les 3 models forms
+    adaptés : machine, interface, domain et switch"""
+    borne = AddBorneForm(
+        request.POST or None,
+        user=request.user
+    )
+    machine = NewMachineForm(
+        request.POST or None,
+        user=request.user
+    )
+    domain = DomainForm(
+        request.POST or None,
+        )
+    if borne.is_valid() and machine.is_valid():
+        user = AssoOption.get_cached_value('utilisateur_asso')
+        if not user:
+            messages.error(request, "L'user association n'existe pas encore,\
+            veuillez le créer ou le linker dans preferences")
+            return redirect(reverse('topologie:index'))
+        new_machine = machine.save(commit=False)
+        new_machine.user = user
+        new_borne = borne.save(commit=False)
+        domain.instance.interface_parent = new_borne
+        if domain.is_valid():
+            new_domain_instance = domain.save(commit=False)
+            with transaction.atomic(), reversion.create_revision():
+                new_machine.save()
+                reversion.set_user(request.user)
+                reversion.set_comment("Création")
+            new_borne.machine = new_machine
+            with transaction.atomic(), reversion.create_revision():
+                new_borne.save()
+                reversion.set_user(request.user)
+                reversion.set_comment("Création")
+            new_domain_instance.interface_parent = new_borne
+            with transaction.atomic(), reversion.create_revision():
+                new_domain_instance.save()
+                reversion.set_user(request.user)
+                reversion.set_comment("Création")
+            messages.success(request, "La borne a été créé")
+            return redirect(reverse('topologie:index-borne'))
+    i_mbf_param = generate_ipv4_mbf_param(borne, False)
+    return form({
+        'topoform': borne,
+        'machineform': machine,
+        'domainform': domain,
+        'i_mbf_param': i_mbf_param
+        }, 'topologie/borne.html', request)
+
+
+@login_required
+@can_edit(Borne)
+def edit_borne(request, borne, borne_id):
+    """ Edition d'un switch. Permet de chambre nombre de ports,
+    place dans le stack, interface et machine associée"""
+    borne_form = EditBorneForm(
+        request.POST or None,
+        user=request.user,
+        instance=borne
+    )
+    machine_form = NewMachineForm(
+        request.POST or None,
+        user=request.user,
+        instance=borne.machine
+    )
+    domain_form = DomainForm(
+        request.POST or None,
+        instance=borne.domain
+        )
+    if borne_form.is_valid() and machine_form.is_valid():
+        user = AssoOption.get_cached_value('utilisateur_asso')
+        if not user:
+            messages.error(request, "L'user association n'existe pas encore,\
+            veuillez le créer ou le linker dans preferences")
+            return redirect(reverse('topologie:index-borne'))
+        new_machine = machine_form.save(commit=False)
+        new_borne = borne_form.save(commit=False)
+        new_domain = domain_form.save(commit=False)
+        with transaction.atomic(), reversion.create_revision():
+            new_machine.save()
+            reversion.set_user(request.user)
+            reversion.set_comment(
+                "Champs modifié(s) : %s" % ', '.join(
+                    field for field in machine_form.changed_data)
+            )
+        with transaction.atomic(), reversion.create_revision():
+            new_borne.save()
+            reversion.set_user(request.user)
+            reversion.set_comment("Champs modifié(s) : %s" % ', '.join(
+                field for field in borne_form.changed_data)
+            )
+            reversion.set_comment("Création")
+        with transaction.atomic(), reversion.create_revision():
+            new_domain.save()
+            reversion.set_user(request.user)
+            reversion.set_comment("Champs modifié(s) : %s" % ', '.join(
+                field for field in domain_form.changed_data)
+            )
+        messages.success(request, "La borne a été modifiée")
+        return redirect(reverse('topologie:index-borne'))
+    i_mbf_param = generate_ipv4_mbf_param(borne_form, False )
+    return form({
+        'topoform': borne_form,
+        'machineform': machine_form,
+        'domainform': domain_form,
+        'i_mbf_param': i_mbf_param
+        }, 'topologie/borne.html', request)
+    
+
 @login_required
 @can_create(Room)
 def new_room(request):

From 53dc43f58627692abe945067119cb1d072027f0d Mon Sep 17 00:00:00 2001
From: grisel-davy <grisel-davy@re2o-server.crans.org>
Date: Sat, 24 Mar 2018 00:51:54 +0100
Subject: [PATCH 06/26] =?UTF-8?q?Cr=C3=A9ation=20de=20la=20page=20d'admini?=
 =?UTF-8?q?stration=20des=20droits=20des=20users?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 logs/templates/logs/aff_stats_droits.html | 110 ++++++++++++++++++++++
 logs/templates/logs/sidebar.html          |   4 +
 logs/templates/logs/stats_droits.html     |  36 +++++++
 logs/urls.py                              |   1 +
 logs/views.py                             |   7 ++
 5 files changed, 158 insertions(+)
 create mode 100644 logs/templates/logs/aff_stats_droits.html
 create mode 100644 logs/templates/logs/stats_droits.html

diff --git a/logs/templates/logs/aff_stats_droits.html b/logs/templates/logs/aff_stats_droits.html
new file mode 100644
index 00000000..dcd7a4db
--- /dev/null
+++ b/logs/templates/logs/aff_stats_droits.html
@@ -0,0 +1,110 @@
+{% comment %}
+Re2o est un logiciel d'administration développé initiallement au rezometz. Il
+se veut agnostique au réseau considéré, de manière à être installable en
+quelques clics.
+
+Copyright © 2017  Gabriel Détraz
+Copyright © 2017  Goulven Kermarec
+Copyright © 2017  Augustin Lemesle
+
+This program is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 2 of the License, or
+(at your option) any later version.
+
+This program is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License along
+with this program; if not, write to the Free Software Foundation, Inc.,
+51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+{% endcomment %}
+
+{% load bootstrap3 %}
+{% load acl %}
+
+<div class="panel-group" id="accordion">
+    {% for droit in stats_list %}
+    <div class="panel panel-default">
+        <div class="panel-heading clearfix" data-parent="#accordion" data-toggle="collapse" data-target="#collapse{{droit.id}}">
+            <h2 class="panel-title pull-left">
+                <i class="fa fa-address-book"></i>
+                {{droit}}
+                <span class="badge">{{droit.user_set.all.count}}</span>
+            </h2>
+            
+        </div>
+            <div class="panel-collapse collapse" id="collapse{{droit.id}}">
+                <div class="panel-body">
+                    
+                    <div class="table-responsive">
+                    <table class="table table-striped">
+                        <thead>
+                        <tr>
+                            <th>Pseudo</th>
+                            <th>Adhésion</th>
+                            <th>Derniere connection</th>
+                            <th>Nombre d'actions</th>
+                            <th>Supprimer </th>
+                        </tr>
+                        </thead>
+                        {% for user in droit.user_set.all %}
+                        <tr>
+                            <td>{{ user.pseudo }}</td>
+                            {% if user.is_adherent %}
+                                <td><p class="text-success">Adhérent</p></td>
+                            {% elif not user.end_adhesion %}
+                                <td><p class="text-danger">On ne s'en souvient plus...</p></td>
+                            {% else %}
+                                <td><p class="text-danger">Plus depuis {{ user.end_adhesion }}</p></td>
+                            {% endif %}
+                            <td>{{ user.last_login }}</td>
+                            <td>{{ user.name }}</td>
+                        </tr>
+                        {% endfor %}
+
+                    </table>
+                    </div>
+                    
+
+                    <!--
+                    <div class="table-responsive" ">
+                    <table class="table table-striped" ">
+                        
+                        {% for user in droit.user_set.all %}
+
+                        <tr>
+                            <div class="table-responsive" ">
+                            <table class="table table-striped" ">
+                                
+                                <tr>
+                                    <td>Pseudo</td>
+                                    <td>Adhésion</td>
+                                    <td>Derniere connection</td>
+                                    <td>Nombre d'actions</td>
+                                </tr>
+
+                                <tr>
+                                    <td>{{ user.name }}</td>
+                                    <td>{{ user.is_adherent }}</td>
+                                    <td>{{ user.last_login }}</td>
+                                    <td>{{ user.name }}</td>
+                                </tr>
+                            
+                            </table>
+                            </div>
+                            
+                        </tr>
+                        
+                            
+                        {% endfor %}
+                    </table>
+                    </div>
+                    -->
+                </div>
+            </div>
+    </div>
+    {% endfor %}
+</div>
diff --git a/logs/templates/logs/sidebar.html b/logs/templates/logs/sidebar.html
index 0e3048e3..03a4bd73 100644
--- a/logs/templates/logs/sidebar.html
+++ b/logs/templates/logs/sidebar.html
@@ -51,5 +51,9 @@ with this program; if not, write to the Free Software Foundation, Inc.,
         <i class="fa fa-users"></i>
         Utilisateurs
     </a>
+    <a class="list-group-item list-group-item-info" href="{% url "logs:stats-droits" %}">
+        <i class="fa fa-balance-scale"></i>
+        Groupes de droit
+    </a>
     {% acl_end %}
 {% endblock %}
diff --git a/logs/templates/logs/stats_droits.html b/logs/templates/logs/stats_droits.html
new file mode 100644
index 00000000..76c20331
--- /dev/null
+++ b/logs/templates/logs/stats_droits.html
@@ -0,0 +1,36 @@
+{% extends "logs/sidebar.html" %}
+{% comment %}
+Re2o est un logiciel d'administration développé initiallement au rezometz. Il
+se veut agnostique au réseau considéré, de manière à être installable en
+quelques clics.
+
+Copyright © 2017  Gabriel Détraz
+Copyright © 2017  Goulven Kermarec
+Copyright © 2017  Augustin Lemesle
+
+This program is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 2 of the License, or
+(at your option) any later version.
+
+This program is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License along
+with this program; if not, write to the Free Software Foundation, Inc.,
+51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+{% endcomment %}
+
+{% load bootstrap3 %}
+
+{% block title %}Statistiques des droits{% endblock %}
+
+{% block content %}
+  <h2>Statistiques des droits</h2>
+  {%  include "logs/aff_stats_droits.html" with stats_list=stats_list %}
+  <br />
+  <br />
+  <br />
+ {% endblock %}
diff --git a/logs/urls.py b/logs/urls.py
index 11009835..98dec281 100644
--- a/logs/urls.py
+++ b/logs/urls.py
@@ -39,4 +39,5 @@ urlpatterns = [
     url(r'^stats_models/$', views.stats_models, name='stats-models'),
     url(r'^stats_users/$', views.stats_users, name='stats-users'),
     url(r'^stats_actions/$', views.stats_actions, name='stats-actions'),
+    url(r'^stats_droits/$', views.stats_droits, name='stats-droits'),
 ]
diff --git a/logs/views.py b/logs/views.py
index 48e52fe0..5b117f2f 100644
--- a/logs/views.py
+++ b/logs/views.py
@@ -446,3 +446,10 @@ def stats_actions(request):
         },
     }
     return render(request, 'logs/stats_users.html', {'stats_list': stats})
+
+@login_required
+@can_view_app('users')
+def stats_droits(request):
+    """Affiche la liste des droits disponibles"""
+    droits=ListRight.objects.all().prefetch_related('user_set')
+    return render(request, 'logs/stats_droits.html', {'stats_list': droits})

From 5de22014eb193c5f5458cc146316ea5ada4ec8fa Mon Sep 17 00:00:00 2001
From: Gabriel Detraz <detraz@crans.org>
Date: Sat, 24 Mar 2018 04:08:48 +0100
Subject: [PATCH 07/26] =?UTF-8?q?Migrations=20des=20bornes=20dans=20la=20c?=
 =?UTF-8?q?lasse=20d=C3=A9di=C3=A9e=20+=20fix=20divers?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 re2o/utils.py                              |  3 +-
 topologie/migrations/0036_transferborne.py | 32 ++++++++++++++++++++++
 2 files changed, 34 insertions(+), 1 deletion(-)
 create mode 100644 topologie/migrations/0036_transferborne.py

diff --git a/re2o/utils.py b/re2o/utils.py
index a3de2a89..d577ba70 100644
--- a/re2o/utils.py
+++ b/re2o/utils.py
@@ -235,7 +235,8 @@ class SortTable:
     }
     TOPOLOGIE_INDEX_BORNE = {
         'borne_name': ['domain__name'],
-        'borne_ipv4': ['borne__ipv4__ipv4'],
+        'borne_ip': ['ipv4__ipv4'],
+        'borne_mac': ['mac_address'],
         'default': ['domain__name']
     }
     TOPOLOGIE_INDEX_STACK = {
diff --git a/topologie/migrations/0036_transferborne.py b/topologie/migrations/0036_transferborne.py
new file mode 100644
index 00000000..2b59e3b9
--- /dev/null
+++ b/topologie/migrations/0036_transferborne.py
@@ -0,0 +1,32 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.7 on 2017-12-31 19:53
+from __future__ import unicode_literals
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('topologie', '0035_auto_20180324_0023'),
+    ]
+
+    def transfer_bornes(apps, schema_editor):
+        db_alias = schema_editor.connection.alias
+        machinetype = apps.get_model("machines", "MachineType")
+        borne = apps.get_model("topologie", "Borne")
+        interface =  apps.get_model("machines", "Interface")
+        bornes_list = machinetype.objects.using(db_alias).filter(type__icontains='borne')
+        if bornes_list:
+            for inter in interface.objects.using(db_alias).filter(type=bornes_list.first()):
+                borne_object = borne()
+                borne_object.interface_ptr_id = inter.pk
+                borne_object.__dict__.update(inter.__dict__) 
+                borne_object.save()
+
+    def untransfer_bornes(apps, schema_editor):
+        return
+
+    operations = [
+    migrations.RunPython(transfer_bornes, untransfer_bornes),
+    ]

From 14a7431f45f0bae296d4e9cfb66fea9d904dad26 Mon Sep 17 00:00:00 2001
From: Gabriel Detraz <detraz@crans.org>
Date: Sat, 24 Mar 2018 04:20:27 +0100
Subject: [PATCH 08/26] Unifi_ap_sync , commande manage.py pour nommer les
 bornes

---
 topologie/management/commands/sync_unifi_ap.py | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/topologie/management/commands/sync_unifi_ap.py b/topologie/management/commands/sync_unifi_ap.py
index 532aa5d5..574c3e98 100644
--- a/topologie/management/commands/sync_unifi_ap.py
+++ b/topologie/management/commands/sync_unifi_ap.py
@@ -21,6 +21,7 @@
 
 from django.core.management.base import BaseCommand, CommandError
 from pymongo import MongoClient
+from topologie.models import Borne
 
 class Command(BaseCommand):
     help = 'Ce script donne un nom aux bornes dans le controleur unifi.
@@ -32,10 +33,15 @@ class Command(BaseCommand):
         db = client.ace
         device = db['device']
 
-    def set_bornes_names(liste_bornes):
-        """Met à jour les noms des bornes dans la bdd du controleur"""
-        for borne in liste_bornes:
-            device.find_one_and_update({'ip': str(borne['ipHostNumber'][0])}, {'$set': {'name': borne['host'][0].split('.')[0]}})
-        return
+        bornes = Borne.objects.all()
+        
+        def set_bornes_names(liste_bornes):
+            """Met à jour les noms des bornes dans la bdd du controleur"""
+            for borne in liste_bornes:
+                if borne.ipv4 and borne.domain:
+                    device.find_one_and_update({'ip': str(borne.ipv4)}, {'$set': {'name': str(borne.domain.name)}})
+            return
+
+        set_bornes_names(bornes)
 
         self.stdout.write(self.style.SUCCESS('Mise à jour de la base de donnée unifi avec succès'))

From 1038625fb84376e0119f8d0172e721e33d5e9258 Mon Sep 17 00:00:00 2001
From: Gabriel Detraz <detraz@crans.org>
Date: Sat, 24 Mar 2018 19:06:49 +0100
Subject: [PATCH 09/26] Edition graphique des shells pour les admin

---
 re2o/templatetags/acl.py                    |  1 +
 re2o/views.py                               |  1 +
 users/forms.py                              | 25 ++++++-
 users/migrations/0070_auto_20180324_1906.py | 19 ++++++
 users/models.py                             | 57 ++++++++++++++++
 users/templates/users/aff_shell.html        | 47 +++++++++++++
 users/templates/users/index_shell.html      | 41 +++++++++++
 users/templates/users/sidebar.html          |  6 ++
 users/urls.py                               | 12 ++++
 users/views.py                              | 75 ++++++++++++++++++++-
 10 files changed, 279 insertions(+), 5 deletions(-)
 create mode 100644 users/migrations/0070_auto_20180324_1906.py
 create mode 100644 users/templates/users/aff_shell.html
 create mode 100644 users/templates/users/index_shell.html

diff --git a/re2o/templatetags/acl.py b/re2o/templatetags/acl.py
index c14fcbd6..c2d3ba24 100644
--- a/re2o/templatetags/acl.py
+++ b/re2o/templatetags/acl.py
@@ -133,6 +133,7 @@ MODEL_NAME = {
     'ServiceUser' : users.models.ServiceUser,
     'School' : users.models.School,
     'ListRight' : users.models.ListRight,
+    'ListShell' : users.models.ListShell,
     'Ban' : users.models.Ban,
     'Whitelist' : users.models.Whitelist,
 }
diff --git a/re2o/views.py b/re2o/views.py
index bfb2e6c5..3220e386 100644
--- a/re2o/views.py
+++ b/re2o/views.py
@@ -65,6 +65,7 @@ HISTORY_BIND = {
         'school' : users.models.School,
         'listright' : users.models.ListRight,
         'serviceuser' : users.models.ServiceUser,
+        'shell' : users.models.ListShell,
     },
     'preferences' : {
         'service' : preferences.models.Service,
diff --git a/users/forms.py b/users/forms.py
index 20121540..81f1e343 100644
--- a/users/forms.py
+++ b/users/forms.py
@@ -41,8 +41,17 @@ from django.utils import timezone
 from django.contrib.auth.models import Group, Permission
 
 from preferences.models import OptionalUser
-from .models import User, ServiceUser, School, ListRight, Whitelist
-from .models import Ban, Adherent, Club
+from .models import (
+    User,
+    ServiceUser,
+    School,
+    ListRight,
+    Whitelist,
+    ListShell,
+    Ban,
+    Adherent,
+    Club
+)
 from re2o.utils import remove_user_room
 
 from re2o.field_permissions import FieldPermissionFormMixin
@@ -460,6 +469,18 @@ class SchoolForm(ModelForm):
         self.fields['name'].label = 'Établissement'
 
 
+class ShellForm(ModelForm):
+    """Edition, creation d'un école"""
+    class Meta:
+        model = ListShell
+        fields = ['shell']
+
+    def __init__(self, *args, **kwargs):
+        prefix = kwargs.pop('prefix', self.Meta.model.__name__)
+        super(ShellForm, self).__init__(*args, prefix=prefix, **kwargs)
+        self.fields['shell'].label = 'Nom du shell'
+
+
 class ListRightForm(ModelForm):
     """Edition, d'un groupe , équivalent à un droit
     Ne peremet pas d'editer le gid, car il sert de primary key"""
diff --git a/users/migrations/0070_auto_20180324_1906.py b/users/migrations/0070_auto_20180324_1906.py
new file mode 100644
index 00000000..fe6ae790
--- /dev/null
+++ b/users/migrations/0070_auto_20180324_1906.py
@@ -0,0 +1,19 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.7 on 2018-03-24 18:06
+from __future__ import unicode_literals
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('users', '0069_club_mailing'),
+    ]
+
+    operations = [
+        migrations.AlterModelOptions(
+            name='listshell',
+            options={'permissions': (('view_listshell', "Peut voir un objet shell quelqu'il soit"),)},
+        ),
+    ]
diff --git a/users/models.py b/users/models.py
index ed62edbb..5c6b5568 100644
--- a/users/models.py
+++ b/users/models.py
@@ -1248,10 +1248,67 @@ class ListShell(models.Model):
 
     shell = models.CharField(max_length=255, unique=True)
 
+    class Meta:
+        permissions = (
+            ("view_listshell", "Peut voir un objet shell quelqu'il soit"),
+        )
+
+    def get_instance(shellid, *args, **kwargs):
+        return ListShell.objects.get(pk=shellid)
+
     def get_pretty_name(self):
         """Return the canonical name of the shell"""
         return self.shell.split("/")[-1]
 
+    def can_create(user_request, *args, **kwargs):
+        """Check if an user can create a ListShell object.
+
+        :param user_request: The user who wants to create a user object.
+        :return: a message and a boolean which is True if the user can create.
+        """
+        return user_request.has_perm('users.add_listshell'), u"Vous n'avez pas le\
+            droit de créer des shells"
+
+    def can_edit(self, user_request, *args, **kwargs):
+        """Check if an user can edit a ListShell object.
+
+        :param self: The Shell which is to be edited.
+        :param user_request: The user who requests to edit self.
+        :return: a message and a boolean which is True if edition is granted.
+        """
+        return user_request.has_perm('users.change_listshell'), u"Vous n'avez pas le\
+            droit d'éditer des shells"
+
+    def can_delete(self, user_request, *args, **kwargs):
+        """Check if an user can delete a ListShell object.
+
+        :param self: The Shell which is to be deleted.
+        :param user_request: The user who requests deletion.
+        :return: True if deletion is granted, and a message.
+        """
+        return user_request.has_perm('users.delete_listshell'), u"Vous n'avez pas le\
+            droit de supprimer des shells"
+
+    def can_view_all(user_request, *args, **kwargs):
+        """Check if an user can access to the list of every ListShell objects
+
+        :param user_request: The user who wants to view the list.
+        :return: True if the user can view the list and an explanation message.
+        """
+        return user_request.has_perm('users.view_listshell'), u"Vous n'avez pas le\
+            droit de voir les shells"
+
+    def can_view(self, user_request, *args, **kwargs):
+        """Check if an user can view a ListShell object.
+
+        :param self: The targeted ListShell instance.
+        :param user_request: The user who ask for viewing the target.
+        :return: A boolean telling if the acces is granted and an explanation
+        text
+        """
+        return user_request.has_perm('users.view_listshell'), u"Vous n'avez pas le\
+            droit de voir les shells"
+
     def __str__(self):
         return self.shell
 
diff --git a/users/templates/users/aff_shell.html b/users/templates/users/aff_shell.html
new file mode 100644
index 00000000..ad325ddf
--- /dev/null
+++ b/users/templates/users/aff_shell.html
@@ -0,0 +1,47 @@
+{% comment %}
+Re2o est un logiciel d'administration développé initiallement au rezometz. Il
+se veut agnostique au réseau considéré, de manière à être installable en
+quelques clics.
+
+Copyright © 2017  Gabriel Détraz
+Copyright © 2017  Goulven Kermarec
+Copyright © 2017  Augustin Lemesle
+
+This program is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 2 of the License, or
+(at your option) any later version.
+
+This program is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License along
+with this program; if not, write to the Free Software Foundation, Inc.,
+51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+{% endcomment %}
+{% load acl %}
+    <table class="table table-striped">
+        <thead>
+            <tr>
+                <th>Shell</th>
+                <th></th>
+            </tr>
+        </thead>
+        {% for shell in shell_list %}
+        <tr>
+            <td>{{ shell.shell }}</td>
+            <td class="text-right">
+                {% can_delete shell %}
+		{% include 'buttons/suppr.html' with href='users:del-shell' id=shell.id %}
+	        {% acl_end %}
+                {% can_edit shell %}
+                {% include 'buttons/edit.html' with href='users:edit-shell' id=shell.id %}
+                {% acl_end %}
+                {% include 'buttons/history.html' with href='users:history' name='shell' id=shell.id %}
+            </td>
+        </tr>
+        {% endfor %}
+    </table>
+
diff --git a/users/templates/users/index_shell.html b/users/templates/users/index_shell.html
new file mode 100644
index 00000000..51fbb551
--- /dev/null
+++ b/users/templates/users/index_shell.html
@@ -0,0 +1,41 @@
+{% extends "users/sidebar.html" %}
+{% comment %}
+Re2o est un logiciel d'administration développé initiallement au rezometz. Il
+se veut agnostique au réseau considéré, de manière à être installable en
+quelques clics.
+
+Copyright © 2017  Gabriel Détraz
+Copyright © 2017  Goulven Kermarec
+Copyright © 2017  Augustin Lemesle
+
+This program is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 2 of the License, or
+(at your option) any later version.
+
+This program is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License along
+with this program; if not, write to the Free Software Foundation, Inc.,
+51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+{% endcomment %}
+
+{% load bootstrap3 %}
+{% load acl %}
+
+{% block title %}Utilisateurs{% endblock %}
+
+{% block content %}
+  <h2>Liste des Shells</h2>
+  {% can_create ListShell %}
+  <a class="btn btn-primary btn-sm" role="button" href="{% url 'users:add-shell'  %}"><i class="fa fa-plus"></i> Ajouter un shell</a>
+  {% acl_end %}
+  {%  include "users/aff_shell.html" with shell_list=shell_list %}
+  <br />
+  <br />
+  <br />
+{% endblock %}
+
diff --git a/users/templates/users/sidebar.html b/users/templates/users/sidebar.html
index 4b561b49..0b21afa7 100644
--- a/users/templates/users/sidebar.html
+++ b/users/templates/users/sidebar.html
@@ -69,6 +69,12 @@ with this program; if not, write to the Free Software Foundation, Inc.,
             Établissements
         </a>
     {% acl_end %}
+    {% can_view_all ListShell %}
+        <a class="list-group-item list-group-item-info" href="{% url "users:index-shell" %}">
+            <i class="fa fa-list-ul"></i>
+            Liste des shells
+        </a>
+    {% acl_end %}
     {% can_view_all ListRight %}
         <a class="list-group-item list-group-item-info" href="{% url "users:index-listright" %}">
             <i class="fa fa-list-ul"></i>
diff --git a/users/urls.py b/users/urls.py
index f15208d5..756498aa 100644
--- a/users/urls.py
+++ b/users/urls.py
@@ -80,10 +80,22 @@ urlpatterns = [
         name='edit-listright'
     ),
     url(r'^del_listright/$', views.del_listright, name='del-listright'),
+    url(r'^add_shell/$', views.add_shell, name='add-shell'),
+    url(
+        r'^edit_shell/(?P<shellid>[0-9]+)$',
+        views.edit_shell,
+        name='edit-shell'
+    ),
+    url(
+        r'^del_shell/(?P<shellid>[0-9]+)$',
+        views.del_shell,
+        name='del-shell'
+    ),
     url(r'^profil/(?P<userid>[0-9]+)$', views.profil, name='profil'),
     url(r'^index_ban/$', views.index_ban, name='index-ban'),
     url(r'^index_white/$', views.index_white, name='index-white'),
     url(r'^index_school/$', views.index_school, name='index-school'),
+    url(r'^index_shell/$', views.index_shell, name='index-shell'),
     url(r'^index_listright/$', views.index_listright, name='index-listright'),
     url(
         r'^index_serviceusers/$',
diff --git a/users/views.py b/users/views.py
index 5d0e31a6..a6a28ed0 100644
--- a/users/views.py
+++ b/users/views.py
@@ -45,8 +45,10 @@ from django.db import IntegrityError
 from django.utils import timezone
 from django.db import transaction
 from django.http import HttpResponse
+from django.http import HttpResponseRedirect
 from django.views.decorators.csrf import csrf_exempt
 
+
 from rest_framework.renderers import JSONRenderer
 
 
@@ -63,6 +65,7 @@ from users.models import (
     ServiceUser,
     Adherent,
     Club,
+    ListShell,
 )
 from users.forms import (
     BanForm,
@@ -72,6 +75,7 @@ from users.forms import (
     NewListRightForm,
     StateForm,
     SchoolForm,
+    ShellForm,
     EditServiceUserForm,
     ServiceUserForm,
     ListRightForm,
@@ -273,8 +277,10 @@ def del_group(request, user, userid, listrightid):
     with transaction.atomic(), reversion.create_revision():
         user.groups.remove(ListRight.objects.get(id=listrightid))
         user.save()
+        reversion.set_user(request.user)
+        reversion.set_comment("Suppression de droit")
         messages.success(request, "Droit supprimé à %s" % user)
-    return redirect(reverse('users:index-listright'))
+    return HttpResponseRedirect(request.META.get('HTTP_REFERER'))
 
 
 @login_required
@@ -492,6 +498,57 @@ def del_school(request, instances):
     return form({'userform': school, 'action_name': 'Supprimer'}, 'users/user.html', request)
 
 
+@login_required
+@can_create(ListShell)
+def add_shell(request):
+    """ Ajouter un établissement d'enseignement à la base de donnée,
+    need cableur"""
+    shell = ShellForm(request.POST or None)
+    if shell.is_valid():
+        with transaction.atomic(), reversion.create_revision():
+            shell.save()
+            reversion.set_user(request.user)
+            reversion.set_comment("Création")
+        messages.success(request, "Le shell a été ajouté")
+        return redirect(reverse('users:index-shell'))
+    return form({'userform': shell, 'action_name':'Ajouter'}, 'users/user.html', request)
+
+
+@login_required
+@can_edit(ListShell)
+def edit_shell(request, shell_instance, shellid):
+    """ Editer un établissement d'enseignement à partir du shellid dans
+    la base de donnée, need cableur"""
+    shell = ShellForm(request.POST or None, instance=shell_instance)
+    if shell.is_valid():
+        with transaction.atomic(), reversion.create_revision():
+            shell.save()
+            reversion.set_user(request.user)
+            reversion.set_comment("Champs modifié(s) : %s" % ', '.join(
+                field for field in shell.changed_data
+            ))
+        messages.success(request, "Le shell a été modifié")
+        return redirect(reverse('users:index-shell'))
+    return form({'userform': shell, 'action_name':'Editer'}, 'users/user.html', request)
+
+
+@login_required
+@can_delete(ListShell)
+def del_shell(request, shell, shellid):
+    """Destruction d'un shell"""
+    if request.method == "POST":
+        with transaction.atomic(), reversion.create_revision():
+            shell.delete()
+            reversion.set_user(request.user)
+        messages.success(request, "Le shell a été détruit")
+        return redirect(reverse('users:index-shell'))
+    return form(
+        {'objet': shell, 'objet_name': 'shell'},
+        'users/delete.html',
+        request
+    )
+
+
 @login_required
 @can_create(ListRight)
 def add_listright(request):
@@ -690,7 +747,7 @@ def index_white(request):
 @login_required
 @can_view_all(School)
 def index_school(request):
-    """ Affiche l'ensemble des établissement, need droit cableur """
+    """ Affiche l'ensemble des établissement"""
     school_list = School.objects.order_by('name')
     return render(
         request,
@@ -699,10 +756,22 @@ def index_school(request):
     )
 
 
+@login_required
+@can_view_all(ListShell)
+def index_shell(request):
+    """ Affiche l'ensemble des shells"""
+    shell_list = ListShell.objects.order_by('shell')
+    return render(
+        request,
+        'users/index_shell.html',
+        {'shell_list': shell_list}
+    )
+
+
 @login_required
 @can_view_all(ListRight)
 def index_listright(request):
-    """ Affiche l'ensemble des droits , need droit cableur """
+    """ Affiche l'ensemble des droits"""
     listright_list = ListRight.objects.order_by('unix_name')\
         .prefetch_related('permissions').prefetch_related('user_set')
     return render(

From fd35836f47c078b33a5d4d8980a2bf4eac753b00 Mon Sep 17 00:00:00 2001
From: grisel-davy <grisel-davy@re2o-server.crans.org>
Date: Sat, 24 Mar 2018 19:42:17 +0100
Subject: [PATCH 10/26] finalisation de la page de gestion des droits

---
 logs/templates/logs/aff_stats_droits.html | 134 +++++++++-------------
 logs/views.py                             |  23 +++-
 2 files changed, 73 insertions(+), 84 deletions(-)

diff --git a/logs/templates/logs/aff_stats_droits.html b/logs/templates/logs/aff_stats_droits.html
index dcd7a4db..bf672b67 100644
--- a/logs/templates/logs/aff_stats_droits.html
+++ b/logs/templates/logs/aff_stats_droits.html
@@ -25,86 +25,58 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 {% load bootstrap3 %}
 {% load acl %}
 
-<div class="panel-group" id="accordion">
-    {% for droit in stats_list %}
-    <div class="panel panel-default">
-        <div class="panel-heading clearfix" data-parent="#accordion" data-toggle="collapse" data-target="#collapse{{droit.id}}">
-            <h2 class="panel-title pull-left">
-                <i class="fa fa-address-book"></i>
-                {{droit}}
-                <span class="badge">{{droit.user_set.all.count}}</span>
-            </h2>
-            
-        </div>
-            <div class="panel-collapse collapse" id="collapse{{droit.id}}">
-                <div class="panel-body">
-                    
-                    <div class="table-responsive">
-                    <table class="table table-striped">
-                        <thead>
-                        <tr>
-                            <th>Pseudo</th>
-                            <th>Adhésion</th>
-                            <th>Derniere connection</th>
-                            <th>Nombre d'actions</th>
-                            <th>Supprimer </th>
-                        </tr>
-                        </thead>
-                        {% for user in droit.user_set.all %}
-                        <tr>
-                            <td>{{ user.pseudo }}</td>
-                            {% if user.is_adherent %}
-                                <td><p class="text-success">Adhérent</p></td>
-                            {% elif not user.end_adhesion %}
-                                <td><p class="text-danger">On ne s'en souvient plus...</p></td>
-                            {% else %}
-                                <td><p class="text-danger">Plus depuis {{ user.end_adhesion }}</p></td>
-                            {% endif %}
-                            <td>{{ user.last_login }}</td>
-                            <td>{{ user.name }}</td>
-                        </tr>
-                        {% endfor %}
-
-                    </table>
-                    </div>
-                    
-
-                    <!--
-                    <div class="table-responsive" ">
-                    <table class="table table-striped" ">
-                        
-                        {% for user in droit.user_set.all %}
-
-                        <tr>
-                            <div class="table-responsive" ">
-                            <table class="table table-striped" ">
-                                
-                                <tr>
-                                    <td>Pseudo</td>
-                                    <td>Adhésion</td>
-                                    <td>Derniere connection</td>
-                                    <td>Nombre d'actions</td>
-                                </tr>
-
-                                <tr>
-                                    <td>{{ user.name }}</td>
-                                    <td>{{ user.is_adherent }}</td>
-                                    <td>{{ user.last_login }}</td>
-                                    <td>{{ user.name }}</td>
-                                </tr>
-                            
-                            </table>
-                            </div>
-                            
-                        </tr>
-                        
-                            
-                        {% endfor %}
-                    </table>
-                    </div>
-                    -->
-                </div>
-            </div>
+{% for droit,users in stats_list.items %}
+<div class="panel panel-default">
+    <div class="panel-heading clearfix" data-parent="#accordion" data-toggle="collapse" data-target="#collapse{{droit.id}}">
+        <h2 class="panel-title pull-left">
+            <i class="fa fa-address-book"></i>
+            {{droit}}
+            <span class="badge">{{users.count}}</span>
+        </h2>
+    </div>
+    <div class="panel-collapse collapse" id="collapse{{droit.id}}">
+        <div class="panel-body">
+            <div class="table-responsive">
+            <table class="table table-striped">
+                <thead>
+                <tr>
+                    <th>Pseudo</th>
+                    <th>Adhésion</th>
+                    <th>Derniere connexion</th>
+                    <th>Nombre d'actions</th>
+                    <th>Date de la dernière action</th>
+                    <th></th>
+                </tr>
+                </thead>
+                {% for utilisateur in users %}
+                <tr>
+                    <td>{{ utilisateur.pseudo }}</td>
+                    {% if utilisateur.is_adherent %}
+                        <td><p class="text-success">Adhérent</p></td>
+                    {% elif not utilisateur.end_adhesion %}
+                        <td><p class="text-warning">On ne s'en souvient plus...</p></td>
+                    {% else %}
+                        <td><p class="text-danger">Plus depuis {{ utilisateur.end_adhesion }}</p></td>
+                    {% endif %}
+                    <td>{{ utilisateur.last_login }}</td>
+                    <td>{{ utilisateur.num }}</td>
+                    {% if not utilisateur.last %}
+                        <td><p class="text-danger">Jamais</p></td>
+                    {% else %}
+                        <td><p class="text-success">{{utilisateur.last}}</p></td>
+                    {% endif %}
+                    <td>
+                        <a href="{% url 'users:del-group' utilisateur.id droit.id %}">
+                            <button type="button" class="btn btn-danger" aria-label="Left Align">
+                                <span class="fa fa-user-times" aria-hidden="true"></span>
+                            </button>
+                        </a>
+                    </td>
+                </tr>
+                {% endfor %}
+            </table>
+            </div>
+        </div>
     </div>
-    {% endfor %}
 </div>
+{% endfor %}
\ No newline at end of file
diff --git a/logs/views.py b/logs/views.py
index 5b117f2f..f40ca3fc 100644
--- a/logs/views.py
+++ b/logs/views.py
@@ -43,10 +43,13 @@ from django.core.paginator import Paginator, EmptyPage, PageNotAnInteger
 from django.contrib import messages
 from django.contrib.auth.decorators import login_required
 from django.db.models import Count
+from django.db.models import Max
 
 from reversion.models import Revision
 from reversion.models import Version, ContentType
 
+from time import time
+
 from users.models import (
     User,
     ServiceUser,
@@ -450,6 +453,20 @@ def stats_actions(request):
 @login_required
 @can_view_app('users')
 def stats_droits(request):
-    """Affiche la liste des droits disponibles"""
-    droits=ListRight.objects.all().prefetch_related('user_set')
-    return render(request, 'logs/stats_droits.html', {'stats_list': droits})
+    """Affiche la liste des droits et les users ayant chaque droit"""
+    depart=time()
+    stats_list={}
+    
+    for droit in ListRight.objects.all().select_related('group_ptr'):#.prefetch_related('group_ptr__user_set__revision_set'):
+        stats_list[droit]=droit.user_set.all().annotate(num=Count('revision'),last=Max('revision__date_created'))
+    
+    # count,last=0,0
+    # for droit in ListRight.objects.all():
+    #     for use in droit.user_set.all():
+    #         countRevision.objects.filter(user=use).count()
+    #         print(Revision.objects.order_by('date_created').last().date_created)
+    #     stats_list[droit]=use.annotate(num=count,las)
+
+    #raise ValueError('temps='+str(time()-depart))
+
+    return render(request, 'logs/stats_droits.html', {'stats_list': stats_list})

From b41507d0e54483da9c60c74ebc1cc030696a03ca Mon Sep 17 00:00:00 2001
From: esum <graillot@crans.org>
Date: Sat, 24 Mar 2018 19:46:32 +0100
Subject: [PATCH 11/26] Ajout de derniere_connexion.py

---
 .../management/commands/derniere_connexion.py | 80 +++++++++++++++++++
 1 file changed, 80 insertions(+)
 create mode 100644 users/management/commands/derniere_connexion.py

diff --git a/users/management/commands/derniere_connexion.py b/users/management/commands/derniere_connexion.py
new file mode 100644
index 00000000..94dbf939
--- /dev/null
+++ b/users/management/commands/derniere_connexion.py
@@ -0,0 +1,80 @@
+# ⁻*- mode: python; coding: utf-8 -*-
+# Re2o est un logiciel d'administration développé initiallement au rezometz. Il
+# se veut agnostique au réseau considéré, de manière à être installable en
+# quelques clics.
+#
+# Copyright © 2018  Benjamin Graillot
+# 
+# Copyright © 2013-2015 Raphaël-David Lasseri <lasseri@crans.org>
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with this program; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+
+import sys
+import re
+from datetime import datetime
+
+from django.core.management.base import BaseCommand, CommandError
+from django.utils.timezone import make_aware
+
+from users.models import User
+
+# Une liste d'expressions régulières à chercher dans les logs.
+# Elles doivent contenir un groupe 'date' et un groupe 'user'.
+# Pour le CAS on prend comme entrée cat ~/cas.log | grep -B 2 -A 2 "ACTION: AUTHENTICATION_SUCCESS"| grep 'WHEN\|WHO'|sed 'N;s/\n/ /'
+COMPILED_REGEX = map(re.compile, [
+    r'^(?P<date>\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}).*(?:'r'dovecot.*Login: user=<|'r'sshd.*Accepted.*for 'r')(?P<user>[^ >]+).*$',
+    r'^(?P<date>.*) LOGIN INFO User logged in : (?P<user>.*)',
+    r'WHO: \[username: (?P<user>.*)\] WHEN: (?P<date>.* CET .*)',
+    r'WHO: \[username: (?P<user>.*)\] WHEN: (?P<date>.* CEST .*)'
+])
+
+# Les formats de date en strftime associés aux expressions ci-dessus.
+DATE_FORMATS = [
+    "%Y-%m-%dT%H:%M:%S",
+    "%d/%b/%Y:%H:%M:%S",
+    "%a %b %d CET %H:%M:%S%Y",
+    "%a %b %d CEST %H:%M:%S%Y"
+]
+
+class Command(BaseCommand):
+    help = 'Update the time of the latest connection for users by matching stdin against a set of regular expressions'
+
+    def handle(self, *args, **options):
+
+        def parse_logs(logfile):
+            """
+            Parse les logs sur l'entrée standard et rempli un dictionnaire
+            ayant pour clef le pseudo de l'adherent
+            """
+            global COMPILED_REGEX, DATE_FORMATS
+
+            parsed_log = {}
+            for line in logfile:
+                for i, regex in enumerate(COMPILED_REGEX):
+                    m = regex.match(line)
+                    if m:
+                        parsed_log[m.group('user')] = make_aware(datetime.strptime(m.group('date'), DATE_FORMATS[i]))
+            return parsed_log
+
+        parsed_log = parse_logs(sys.stdin)
+
+        for pseudo in parsed_log:
+            for user in User.objects.filter(pseudo=pseudo):
+                last_login = parsed_log.get(user.pseudo, user.last_login)
+                if not user.last_login:
+                    user.last_login = last_login
+                elif last_login > user.last_login:
+                    user.last_login = last_login
+                user.save()

From 51c5fc812690cf416645164bbeebf5d024dcadf2 Mon Sep 17 00:00:00 2001
From: Gabriel Detraz <detraz@crans.org>
Date: Sat, 24 Mar 2018 21:19:52 +0100
Subject: [PATCH 12/26] Defini un shell par defaut

---
 .../migrations/0031_auto_20180323_0218.py     | 20 +++++++++++++++++
 .../0032_optionaluser_shell_default.py        | 22 +++++++++++++++++++
 preferences/models.py                         |  6 +++++
 .../preferences/display_preferences.html      |  4 +++-
 users/models.py                               | 10 +++++++--
 5 files changed, 59 insertions(+), 3 deletions(-)
 create mode 100644 preferences/migrations/0031_auto_20180323_0218.py
 create mode 100644 preferences/migrations/0032_optionaluser_shell_default.py

diff --git a/preferences/migrations/0031_auto_20180323_0218.py b/preferences/migrations/0031_auto_20180323_0218.py
new file mode 100644
index 00000000..25c98cbf
--- /dev/null
+++ b/preferences/migrations/0031_auto_20180323_0218.py
@@ -0,0 +1,20 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.7 on 2018-03-23 01:18
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('preferences', '0030_merge_20180320_1419'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='generaloption',
+            name='email_from',
+            field=models.EmailField(default='www-data@example.com', max_length=254),
+        ),
+    ]
diff --git a/preferences/migrations/0032_optionaluser_shell_default.py b/preferences/migrations/0032_optionaluser_shell_default.py
new file mode 100644
index 00000000..365a616e
--- /dev/null
+++ b/preferences/migrations/0032_optionaluser_shell_default.py
@@ -0,0 +1,22 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.7 on 2018-03-24 19:22
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('users', '0070_auto_20180324_1906'),
+        ('preferences', '0031_auto_20180323_0218'),
+    ]
+
+    operations = [
+        migrations.AddField(
+            model_name='optionaluser',
+            name='shell_default',
+            field=models.OneToOneField(blank=True, null=True, on_delete=django.db.models.deletion.PROTECT, to='users.ListShell'),
+        ),
+    ]
diff --git a/preferences/models.py b/preferences/models.py
index 80c3271e..5238e1a5 100644
--- a/preferences/models.py
+++ b/preferences/models.py
@@ -89,6 +89,12 @@ class OptionalUser(PreferencesModel):
         default=False,
         help_text="Un nouvel utilisateur peut se créer son compte sur re2o"
     )
+    shell_default = models.OneToOneField(
+        'users.ListShell',
+        on_delete=models.PROTECT,
+        blank=True,
+        null=True
+    )
 
     class Meta:
         permissions = (
diff --git a/preferences/templates/preferences/display_preferences.html b/preferences/templates/preferences/display_preferences.html
index 26fc0308..4b234c5c 100644
--- a/preferences/templates/preferences/display_preferences.html
+++ b/preferences/templates/preferences/display_preferences.html
@@ -68,7 +68,9 @@ with this program; if not, write to the Free Software Foundation, Inc.,
         <tr>
 	    <th>Auto inscription</th>
             <td>{{ useroptions.self_adhesion }}</td>
-        </tr>
+ 	    <th>Shell par défaut des utilisateurs</th>
+            <td>{{ useroptions.shell_default }}</td>       
+	</tr>
     </table>
     <h4>Préférences machines</h4>
         <a class="btn btn-primary btn-sm" role="button" href="{% url 'preferences:edit-options' 'OptionalMachine' %}">
diff --git a/users/models.py b/users/models.py
index 5c6b5568..61f2bef5 100644
--- a/users/models.py
+++ b/users/models.py
@@ -300,6 +300,12 @@ class User(FieldPermissionModelMixin, AbstractBaseUser, PermissionsMixin):
         """ Renvoie seulement le nom"""
         return self.surname
 
+    @property
+    def get_shell(self):
+        """ A utiliser de préférence, prend le shell par défaut
+        si il n'est pas défini"""
+        return self.shell or OptionalUser.get_cached_value('shell_default')
+
     def end_adhesion(self):
         """ Renvoie la date de fin d'adhésion d'un user. Examine les objets
         cotisation"""
@@ -502,8 +508,8 @@ class User(FieldPermissionModelMixin, AbstractBaseUser, PermissionsMixin):
             user_ldap.gid = LDAP['user_gid']
             user_ldap.user_password = self.password[:6] + self.password[7:]
             user_ldap.sambat_nt_password = self.pwd_ntlm.upper()
-            if self.shell:
-                user_ldap.login_shell = self.shell.shell
+            if self.get_shell:
+                user_ldap.login_shell = str(self.get_shell)
             if self.state == self.STATE_DISABLED:
                 user_ldap.shadowexpire = str(0)
             else:

From 3a2e0073726739d505a8eed0cef4124adec9900a Mon Sep 17 00:00:00 2001
From: Gabriel Detraz <detraz@crans.org>
Date: Sun, 25 Mar 2018 04:05:26 +0200
Subject: [PATCH 13/26] =?UTF-8?q?Switch=20h=C3=A9rite=20de=20interface?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 topologie/forms.py                            |  34 +++---
 .../migrations/0037_auto_20180325_0127.py     |  33 +++++
 topologie/migrations/0038_transfersw.py       |  37 ++++++
 topologie/migrations/0039_port_new_switch.py  |  21 ++++
 topologie/migrations/0040_transferports.py    |  28 +++++
 topologie/migrations/0041_transferportsw.py   |  20 +++
 topologie/migrations/0042_transferswitch.py   |  18 +++
 topologie/migrations/0043_renamenewswitch.py  |  16 +++
 topologie/models.py                           |  16 +--
 topologie/templates/topologie/aff_switch.html |   6 +-
 topologie/templates/topologie/switch.html     |  29 +----
 .../topologie/{borne.html => topo_more.html}  |   6 +-
 topologie/views.py                            | 115 ++++++++----------
 13 files changed, 253 insertions(+), 126 deletions(-)
 create mode 100644 topologie/migrations/0037_auto_20180325_0127.py
 create mode 100644 topologie/migrations/0038_transfersw.py
 create mode 100644 topologie/migrations/0039_port_new_switch.py
 create mode 100644 topologie/migrations/0040_transferports.py
 create mode 100644 topologie/migrations/0041_transferportsw.py
 create mode 100644 topologie/migrations/0042_transferswitch.py
 create mode 100644 topologie/migrations/0043_renamenewswitch.py
 rename topologie/templates/topologie/{borne.html => topo_more.html} (90%)

diff --git a/topologie/forms.py b/topologie/forms.py
index 42572fe7..cc9b59d8 100644
--- a/topologie/forms.py
+++ b/topologie/forms.py
@@ -78,7 +78,7 @@ class EditPortForm(ModelForm):
         self.fields['machine_interface'].queryset = Interface.objects.all()\
             .select_related('domain__extension')
         self.fields['related'].queryset = Port.objects.all()\
-            .select_related('switch__switch_interface__domain__extension')\
+            .select_related('switch__domain__extension')\
             .order_by('switch', 'port')
 
 
@@ -95,7 +95,7 @@ class AddPortForm(ModelForm):
         self.fields['machine_interface'].queryset = Interface.objects.all()\
             .select_related('domain__extension')
         self.fields['related'].queryset = Port.objects.all()\
-            .select_related('switch__switch_interface__domain__extension')\
+            .select_related('switch__domain__extension')\
             .order_by('switch', 'port')
 
 
@@ -126,32 +126,30 @@ class EditBorneForm(EditInterfaceForm):
         fields = ['machine', 'type', 'ipv4', 'mac_address', 'details', 'location']
 
 
-class EditSwitchForm(ModelForm):
+class EditSwitchForm(EditInterfaceForm):
     """Permet d'éditer un switch : nom et nombre de ports"""
     class Meta:
         model = Switch
-        fields = '__all__'
+        fields = ['machine', 'type', 'ipv4', 'mac_address', 'details', 'location', 'number', 'stack', 'stack_member_id']
 
-    def __init__(self, *args, **kwargs):
-        prefix = kwargs.pop('prefix', self.Meta.model.__name__)
-        super(EditSwitchForm, self).__init__(*args, prefix=prefix, **kwargs)
-        self.fields['switch_interface'].queryset = Interface.objects.all()\
-            .select_related('domain__extension')
-        self.fields['location'].label = 'Localisation'
-        self.fields['number'].label = 'Nombre de ports'
+   # def __init__(self, *args, **kwargs):
+   #     prefix = kwargs.pop('prefix', self.Meta.model.__name__)
+   #     super(EditInterfaceForm, self).__init__(*args, prefix=prefix, **kwargs)
+   #     self.fields['location'].label = 'Localisation'
+   #     self.fields['number'].label = 'Nombre de ports'
 
 
-class NewSwitchForm(ModelForm):
+class NewSwitchForm(EditInterfaceForm):
     """Permet de créer un switch : emplacement, paramètres machine,
     membre d'un stack (option), nombre de ports (number)"""
     class Meta(EditSwitchForm.Meta):
-        fields = ['location', 'number', 'details', 'stack', 'stack_member_id']
+        fields = ['type', 'ipv4', 'mac_address', 'details', 'location', 'number', 'stack', 'stack_member_id']
 
-    def __init__(self, *args, **kwargs):
-        prefix = kwargs.pop('prefix', self.Meta.model.__name__)
-        super(NewSwitchForm, self).__init__(*args, prefix=prefix, **kwargs)
-        self.fields['location'].label = 'Localisation'
-        self.fields['number'].label = 'Nombre de ports'
+    #def __init__(self, *args, **kwargs):
+    #    prefix = kwargs.pop('prefix', self.Meta.model.__name__)
+    #    super(NewSwitchForm, self).__init__(*args, prefix=prefix, **kwargs)
+    #    self.fields['location'].label = 'Localisation'
+    #    self.fields['number'].label = 'Nombre de ports'
 
 class EditRoomForm(ModelForm):
     """Permet d'éediter le nom et commentaire d'une prise murale"""
diff --git a/topologie/migrations/0037_auto_20180325_0127.py b/topologie/migrations/0037_auto_20180325_0127.py
new file mode 100644
index 00000000..30b34e58
--- /dev/null
+++ b/topologie/migrations/0037_auto_20180325_0127.py
@@ -0,0 +1,33 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.7 on 2018-03-25 00:27
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('machines', '0076_auto_20180130_1623'),
+        ('topologie', '0036_transferborne'),
+    ]
+
+    operations = [
+        migrations.CreateModel(
+            name='NewSwitch',
+            fields=[
+                ('interface_ptr', models.OneToOneField(auto_created=True, on_delete=django.db.models.deletion.CASCADE, parent_link=True, primary_key=True, serialize=False, to='machines.Interface')),
+                ('location', models.CharField(max_length=255)),
+                ('number', models.PositiveIntegerField()),
+                ('stack_member_id', models.PositiveIntegerField(blank=True, null=True)),
+                ('model', models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.SET_NULL, to='topologie.ModelSwitch')),
+                ('stack', models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.SET_NULL, to='topologie.Stack')),
+            ],
+            bases=('machines.interface',),
+        ),
+        migrations.AlterUniqueTogether(
+            name='newswitch',
+            unique_together=set([('stack', 'stack_member_id')]),
+        ),
+    ]
diff --git a/topologie/migrations/0038_transfersw.py b/topologie/migrations/0038_transfersw.py
new file mode 100644
index 00000000..6f79825f
--- /dev/null
+++ b/topologie/migrations/0038_transfersw.py
@@ -0,0 +1,37 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.7 on 2017-12-31 19:53
+from __future__ import unicode_literals
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('topologie', '0037_auto_20180325_0127'),
+    ]
+
+    def transfer_sw(apps, schema_editor):
+        db_alias = schema_editor.connection.alias
+        newswitch = apps.get_model("topologie", "NewSwitch")
+        switch = apps.get_model("topologie", "Switch")
+        interface =  apps.get_model("machines", "Interface")
+        sw_list = switch.objects.using(db_alias).all()
+        for sw in sw_list:
+            new_sw = newswitch()
+            new_sw.location = sw.location
+            new_sw.number = sw.number
+            new_sw.details = sw.details
+            new_sw.stack = sw.stack
+            new_sw.stack_member_id = sw.stack_member_id
+            new_sw.model = sw.model
+            new_sw.interface_ptr_id = sw.switch_interface.pk
+            new_sw.__dict__.update(sw.switch_interface.__dict__) 
+            new_sw.save()
+
+    def untransfer_sw(apps, schema_editor):
+        return
+
+    operations = [
+    migrations.RunPython(transfer_sw, untransfer_sw),
+    ]
diff --git a/topologie/migrations/0039_port_new_switch.py b/topologie/migrations/0039_port_new_switch.py
new file mode 100644
index 00000000..33dda2b4
--- /dev/null
+++ b/topologie/migrations/0039_port_new_switch.py
@@ -0,0 +1,21 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.7 on 2018-03-25 00:52
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('topologie', '0038_transfersw'),
+    ]
+
+    operations = [
+        migrations.AddField(
+            model_name='port',
+            name='new_switch',
+            field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.CASCADE, related_name='ports', to='topologie.NewSwitch'),
+        ),
+    ]
diff --git a/topologie/migrations/0040_transferports.py b/topologie/migrations/0040_transferports.py
new file mode 100644
index 00000000..7f72edc2
--- /dev/null
+++ b/topologie/migrations/0040_transferports.py
@@ -0,0 +1,28 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.7 on 2017-12-31 19:53
+from __future__ import unicode_literals
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('topologie', '0039_port_new_switch'),
+    ]
+
+    def transfer_port(apps, schema_editor):
+        db_alias = schema_editor.connection.alias
+        port = apps.get_model("topologie", "Port")
+        switch = apps.get_model("topologie", "NewSwitch")
+        port_list = port.objects.using(db_alias).all()
+        for p in port_list:
+            p.new_switch = switch.objects.filter(interface_ptr=p.switch.switch_interface).first()
+            p.save()
+
+    def untransfer_port(apps, schema_editor):
+        return
+
+    operations = [
+    migrations.RunPython(transfer_port, untransfer_port),
+    ]
diff --git a/topologie/migrations/0041_transferportsw.py b/topologie/migrations/0041_transferportsw.py
new file mode 100644
index 00000000..a629c7e6
--- /dev/null
+++ b/topologie/migrations/0041_transferportsw.py
@@ -0,0 +1,20 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.7 on 2017-12-31 19:53
+from __future__ import unicode_literals
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('topologie', '0040_transferports'),
+    ]
+
+    operations = [
+    migrations.RemoveField(
+        model_name='port',
+        name='switch',
+    ),
+    migrations.RenameField('Port', 'new_switch', 'switch')
+    ]
diff --git a/topologie/migrations/0042_transferswitch.py b/topologie/migrations/0042_transferswitch.py
new file mode 100644
index 00000000..96ad49dc
--- /dev/null
+++ b/topologie/migrations/0042_transferswitch.py
@@ -0,0 +1,18 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.7 on 2017-12-31 19:53
+from __future__ import unicode_literals
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('topologie', '0041_transferportsw'),
+    ]
+
+    operations = [
+    migrations.DeleteModel(
+        name='Switch',
+    ),
+    ]
diff --git a/topologie/migrations/0043_renamenewswitch.py b/topologie/migrations/0043_renamenewswitch.py
new file mode 100644
index 00000000..3deeced4
--- /dev/null
+++ b/topologie/migrations/0043_renamenewswitch.py
@@ -0,0 +1,16 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.7 on 2017-12-31 19:53
+from __future__ import unicode_literals
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('topologie', '0042_transferswitch'),
+    ]
+
+    operations = [
+    migrations.RenameModel(old_name='NewSwitch', new_name='Switch'),
+    ]
diff --git a/topologie/models.py b/topologie/models.py
index 5c48773f..ca5c7093 100644
--- a/topologie/models.py
+++ b/topologie/models.py
@@ -156,7 +156,7 @@ class Borne(Interface):
         return True, None
 
 
-class Switch(models.Model):
+class Switch(Interface):
     """ Definition d'un switch. Contient un nombre de ports (number),
     un emplacement (location), un stack parent (optionnel, stack)
     et un id de membre dans le stack (stack_member_id)
@@ -170,13 +170,9 @@ class Switch(models.Model):
     id_max de la stack parente"""
     PRETTY_NAME = "Switch / Commutateur"
 
-    switch_interface = models.OneToOneField(
-        'machines.Interface',
-        on_delete=models.CASCADE
-        )
+
     location = models.CharField(max_length=255)
     number = models.PositiveIntegerField()
-    details = models.CharField(max_length=255, blank=True)
     stack = models.ForeignKey(
         'topologie.Stack',
         blank=True,
@@ -194,7 +190,7 @@ class Switch(models.Model):
     class Meta:
         unique_together = ('stack', 'stack_member_id')
         permissions = (
-            ("view_switch", "Peut voir un objet switch"),
+            ("view_newswitch", "Peut voir un objet switch"),
         )
 
     def get_instance(switch_id, *args, **kwargs):
@@ -224,8 +220,8 @@ class Switch(models.Model):
             return False, u"Vous n'avez pas le droit de voir les switch"
         return True, None
  
-    def __str__(self):
-        return self.location + ' ' + str(self.switch_interface)
+#    def __str__(self):
+#        return self.location + ' ' + str(self.switch_interface)
 
     def clean(self):
         """ Verifie que l'id stack est dans le bon range"""
@@ -421,7 +417,7 @@ class Port(models.Model):
 
     def get_instance(port_id, *args, **kwargs):
         return Port.objects\
-            .select_related('switch__switch_interface__domain__extension')\
+            .select_related('switch__domain__extension')\
             .select_related('machine_interface__domain__extension')\
             .select_related('machine_interface__switch')\
             .select_related('room')\
diff --git a/topologie/templates/topologie/aff_switch.html b/topologie/templates/topologie/aff_switch.html
index 38980736..c8c9e6e0 100644
--- a/topologie/templates/topologie/aff_switch.html
+++ b/topologie/templates/topologie/aff_switch.html
@@ -46,10 +46,10 @@ with this program; if not, write to the Free Software Foundation, Inc.,
    <tr>
        <td>
            <a title="Configuer" href="{% url 'topologie:index-port' switch.pk %}">
-               {{switch.switch_interface}}
+               {{switch}}
            </a>
        </td>
-       <td>{{switch.switch_interface.ipv4}}</td>
+       <td>{{switch.ipv4}}</td>
        <td>{{switch.location}}</td>
        <td>{{switch.number}}</td>
        <td>{{switch.stack.name}}</td>
@@ -62,7 +62,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
            {% include 'buttons/edit.html' with href='topologie:edit-switch' id=switch.pk %}
 	   {% acl_end %}
 	   {% can_delete switch %}
-           {% include 'buttons/suppr.html' with href='machines:del-interface' id=switch.switch_interface.id %} 
+           {% include 'buttons/suppr.html' with href='machines:del-interface' id=switch.id %} 
 	   {% acl_end %}
 	   {% can_create Port %}
 	   {% include 'buttons/add.html' with href='topologie:create-ports' id=switch.pk desc='Création de ports'%}
diff --git a/topologie/templates/topologie/switch.html b/topologie/templates/topologie/switch.html
index 54842d55..4b334896 100644
--- a/topologie/templates/topologie/switch.html
+++ b/topologie/templates/topologie/switch.html
@@ -32,44 +32,17 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 {% if topoform %}
 {% bootstrap_form_errors topoform %}
 {% endif %}
-{% if machineform %}
-{% bootstrap_form_errors machineform %}
-{% endif %}
-{% if interfaceform %}
-{% bootstrap_form_errors interfaceform %}
-{% endif %}
-{% if domainform %}
-{% bootstrap_form_errors domainform %}
-{% endif %}
 
 
 
-{% if id_switch %}
 <a class="btn btn-primary" href="{% url "topologie:index-port" id_switch %}" role="button">{% bootstrap_icon "list" %} Aller à la liste des ports</a>
-{% endif %}
 <form class="form" method="post">
     {% csrf_token %}
     {% if topoform %}
     <h3>Réglage spécifiques du switch</h3>
     {% massive_bootstrap_form topoform 'switch_interface' %}
     {% endif %}
-    {% if machineform %}
-    <h3>Réglages généraux de la machine associée au switch</h3>
-    {% massive_bootstrap_form machineform 'user' %}
-    {% endif %}
-    {% if interfaceform %}
-    <h3>Réglages généraux de l'interface associée au switch</h3>
-        {% if i_mbf_param %}
-    {% massive_bootstrap_form interfaceform 'ipv4,machine' mbf_param=i_mbf_param %}
-        {% else %}
-    {% massive_bootstrap_form interfaceform 'ipv4,machine' %}
-        {% endif %}
-    {% endif %}
-    {% if domainform %}
-    <h3>Nom de la machine</h3>
-    {% bootstrap_form domainform %}
-    {% endif %}
-    {% bootstrap_button "Créer ou modifier" button_type="submit" icon="ok" %}
+    {% bootstrap_button "Créer" button_type="submit" icon="ok" %}
 </form>
   <br />
   <br />
diff --git a/topologie/templates/topologie/borne.html b/topologie/templates/topologie/topo_more.html
similarity index 90%
rename from topologie/templates/topologie/borne.html
rename to topologie/templates/topologie/topo_more.html
index 57e015d5..d1147ff8 100644
--- a/topologie/templates/topologie/borne.html
+++ b/topologie/templates/topologie/topo_more.html
@@ -26,7 +26,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 {% load bootstrap3 %}
 {% load massive_bootstrap_form %}
 
-{% block title %}Création et modification d'une borne{% endblock %}
+{% block title %}Création et modification d'un objet topologie{% endblock %}
 
 {% block content %}
 {% if topoform %}
@@ -44,11 +44,11 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 <form class="form" method="post">
     {% csrf_token %}
     {% if topoform %}
-    <h3>Réglage spécifiques de la borne</h3>
+    <h3>Réglage spécifiques du {{ device }}</h3>
     {% massive_bootstrap_form topoform 'ipv4,machine' mbf_param=i_mbf_param%}
     {% endif %}
     {% if machineform %}
-    <h3>Réglages généraux de la machine associée à la borne</h3>
+    <h3>Réglages généraux de la machine associée au {{ device }}</h3>
     {% massive_bootstrap_form machineform 'user' %}
     {% endif %}
     {% if domainform %}
diff --git a/topologie/views.py b/topologie/views.py
index 4c50acf5..97091a83 100644
--- a/topologie/views.py
+++ b/topologie/views.py
@@ -92,9 +92,9 @@ from preferences.models import AssoOption, GeneralOption
 def index(request):
     """ Vue d'affichage de tous les swicthes"""
     switch_list = Switch.objects\
-        .select_related('switch_interface__domain__extension')\
-        .select_related('switch_interface__ipv4')\
-        .select_related('switch_interface__domain')\
+        .select_related('domain__extension')\
+        .select_related('ipv4')\
+        .select_related('domain')\
         .select_related('stack')
     switch_list = SortTable.sort(
         switch_list,
@@ -128,7 +128,7 @@ def index_port(request, switch, switch_id):
         .select_related('machine_interface__domain__extension')\
         .select_related('machine_interface__machine__user')\
         .select_related(
-            'related__switch__switch_interface__domain__extension'
+            'related__switch__domain__extension'
         )\
         .select_related('switch')
     port_list = SortTable.sort(
@@ -203,7 +203,7 @@ def index_borne(request):
 def index_stack(request):
     """Affichage de la liste des stacks (affiche l'ensemble des switches)"""
     stack_list = Stack.objects\
-        .prefetch_related('switch_set__switch_interface__domain__extension')
+        .prefetch_related('switch_set__domain__extension')
     stack_list = SortTable.sort(
         stack_list,
         request.GET.get('col'),
@@ -381,19 +381,18 @@ def new_switch(request):
     """ Creation d'un switch. Cree en meme temps l'interface et la machine
     associée. Vue complexe. Appelle successivement les 4 models forms
     adaptés : machine, interface, domain et switch"""
-    switch = NewSwitchForm(request.POST or None)
+    switch = NewSwitchForm(
+        request.POST or None,
+        user=request.user
+    )
     machine = NewMachineForm(
         request.POST or None,
         user=request.user
     )
-    interface = AddInterfaceForm(
-        request.POST or None,
-        user=request.user
-        )
     domain = DomainForm(
         request.POST or None,
         )
-    if switch.is_valid() and machine.is_valid() and interface.is_valid():
+    if switch.is_valid() and machine.is_valid():
         user = AssoOption.get_cached_value('utilisateur_asso')
         if not user:
             messages.error(request, "L'user association n'existe pas encore,\
@@ -401,38 +400,34 @@ def new_switch(request):
             return redirect(reverse('topologie:index'))
         new_machine = machine.save(commit=False)
         new_machine.user = user
-        new_interface = interface.save(commit=False)
         new_switch_instance = switch.save(commit=False)
-        new_domain_instance = domain.save(commit=False)
-        with transaction.atomic(), reversion.create_revision():
-            new_machine.save()
-            reversion.set_user(request.user)
-            reversion.set_comment("Création")
-        new_interface.machine = new_machine
-        with transaction.atomic(), reversion.create_revision():
-            new_interface.save()
-            reversion.set_user(request.user)
-            reversion.set_comment("Création")
-        new_domain_instance.interface_parent = new_interface
-        with transaction.atomic(), reversion.create_revision():
-            new_domain_instance.save()
-            reversion.set_user(request.user)
-            reversion.set_comment("Création")
-        new_switch_instance.switch_interface = new_interface
-        with transaction.atomic(), reversion.create_revision():
-            new_switch_instance.save()
-            reversion.set_user(request.user)
-            reversion.set_comment("Création")
-        messages.success(request, "Le switch a été créé")
-        return redirect(reverse('topologie:index'))
-    i_mbf_param = generate_ipv4_mbf_param( interface, False)
+        domain.instance.interface_parent = new_switch_instance
+        if domain.is_valid():
+            new_domain_instance = domain.save(commit=False)
+            with transaction.atomic(), reversion.create_revision():
+                new_machine.save()
+                reversion.set_user(request.user)
+                reversion.set_comment("Création")
+            new_switch_instance.machine = new_machine
+            with transaction.atomic(), reversion.create_revision():
+                new_switch_instance.save()
+                reversion.set_user(request.user)
+                reversion.set_comment("Création")
+            new_domain_instance.interface_parent = new_switch_instance
+            with transaction.atomic(), reversion.create_revision():
+                new_domain_instance.save()
+                reversion.set_user(request.user)
+                reversion.set_comment("Création")
+            messages.success(request, "Le switch a été créé")
+            return redirect(reverse('topologie:index'))
+    i_mbf_param = generate_ipv4_mbf_param(switch, False)
     return form({
         'topoform': switch,
         'machineform': machine,
-        'interfaceform': interface,
         'domainform': domain,
-        'i_mbf_param': i_mbf_param
-        }, 'topologie/switch.html', request)
+        'i_mbf_param': i_mbf_param,
+        'device' : 'switch',
+        }, 'topologie/topo_more.html', request)
 
 
 @login_required
@@ -470,7 +465,6 @@ def create_ports(request, switch_id):
             'topologie:index-port',
             kwargs={'switch_id':switch_id}
             ))
-
     return form({'id_switch': switch_id, 'topoform': port_form}, 'topologie/switch.html', request)
 
 
@@ -480,24 +474,21 @@ def edit_switch(request, switch, switch_id):
     """ Edition d'un switch. Permet de chambre nombre de ports,
     place dans le stack, interface et machine associée"""
 
-    switch_form = EditSwitchForm(request.POST or None, instance=switch)
-    machine_form = EditMachineForm(
+    switch_form = EditSwitchForm(
         request.POST or None,
-        instance=switch.switch_interface.machine,
+        instance=switch,
         user=request.user
         )
-    interface_form = EditInterfaceForm(
+    machine_form = EditMachineForm(
         request.POST or None,
-        instance=switch.switch_interface,
+        instance=switch.machine,
         user=request.user
         )
     domain_form = DomainForm(
         request.POST or None,
-        instance=switch.switch_interface.domain
+        instance=switch.domain
         )
-    if switch_form.is_valid() and machine_form.is_valid()\
-            and interface_form.is_valid():
-        new_interface = interface_form.save(commit=False)
+    if switch_form.is_valid() and machine_form.is_valid():
         new_machine = machine_form.save(commit=False)
         new_switch_instance = switch_form.save(commit=False)
         new_domain = domain_form.save(commit=False)
@@ -510,10 +501,10 @@ def edit_switch(request, switch, switch_id):
                     )
                 )
         with transaction.atomic(), reversion.create_revision():
-            new_interface.save()
+            new_switch_instance.save()
             reversion.set_user(request.user)
             reversion.set_comment("Champs modifié(s) : %s" % ', '.join(
-                field for field in interface_form.changed_data)
+                field for field in switch_form.changed_data)
                                  )
         with transaction.atomic(), reversion.create_revision():
             new_domain.save()
@@ -521,23 +512,17 @@ def edit_switch(request, switch, switch_id):
             reversion.set_comment("Champs modifié(s) : %s" % ', '.join(
                 field for field in domain_form.changed_data)
                                  )
-        with transaction.atomic(), reversion.create_revision():
-            new_switch_instance.save()
-            reversion.set_user(request.user)
-            reversion.set_comment("Champs modifié(s) : %s" % ', '.join(
-                field for field in switch_form.changed_data)
-                                 )
         messages.success(request, "Le switch a bien été modifié")
         return redirect(reverse('topologie:index'))
-    i_mbf_param = generate_ipv4_mbf_param( interface_form, False )
+    i_mbf_param = generate_ipv4_mbf_param(switch_form, False )
     return form({
         'id_switch': switch_id,
         'topoform': switch_form,
         'machineform': machine_form,
-        'interfaceform': interface_form,
         'domainform': domain_form,
-        'i_mbf_param': i_mbf_param
-        }, 'topologie/switch.html', request)
+        'i_mbf_param': i_mbf_param,
+        'device' : 'switch',
+        }, 'topologie/topo_more.html', request)
 
 
 @login_required
@@ -590,8 +575,9 @@ def new_borne(request):
         'topoform': borne,
         'machineform': machine,
         'domainform': domain,
-        'i_mbf_param': i_mbf_param
-        }, 'topologie/borne.html', request)
+        'i_mbf_param': i_mbf_param,
+        'device' : 'wifi ap',
+        }, 'topologie/topo_more.html', request)
 
 
 @login_required
@@ -649,8 +635,9 @@ def edit_borne(request, borne, borne_id):
         'topoform': borne_form,
         'machineform': machine_form,
         'domainform': domain_form,
-        'i_mbf_param': i_mbf_param
-        }, 'topologie/borne.html', request)
+        'i_mbf_param': i_mbf_param,
+        'device' : 'wifi ap',
+        }, 'topologie/topo_more.html', request)
     
 
 @login_required

From 3293dff1a4af761971044ef6ad1ca3bdc288f5ba Mon Sep 17 00:00:00 2001
From: Gabriel Detraz <detraz@crans.org>
Date: Sun, 25 Mar 2018 04:51:48 +0200
Subject: [PATCH 14/26] Fix assignation de l'ip

---
 topologie/forms.py  | 11 -----------
 topologie/models.py |  9 ++++-----
 2 files changed, 4 insertions(+), 16 deletions(-)

diff --git a/topologie/forms.py b/topologie/forms.py
index cc9b59d8..6e37bb0c 100644
--- a/topologie/forms.py
+++ b/topologie/forms.py
@@ -132,12 +132,6 @@ class EditSwitchForm(EditInterfaceForm):
         model = Switch
         fields = ['machine', 'type', 'ipv4', 'mac_address', 'details', 'location', 'number', 'stack', 'stack_member_id']
 
-   # def __init__(self, *args, **kwargs):
-   #     prefix = kwargs.pop('prefix', self.Meta.model.__name__)
-   #     super(EditInterfaceForm, self).__init__(*args, prefix=prefix, **kwargs)
-   #     self.fields['location'].label = 'Localisation'
-   #     self.fields['number'].label = 'Nombre de ports'
-
 
 class NewSwitchForm(EditInterfaceForm):
     """Permet de créer un switch : emplacement, paramètres machine,
@@ -145,11 +139,6 @@ class NewSwitchForm(EditInterfaceForm):
     class Meta(EditSwitchForm.Meta):
         fields = ['type', 'ipv4', 'mac_address', 'details', 'location', 'number', 'stack', 'stack_member_id']
 
-    #def __init__(self, *args, **kwargs):
-    #    prefix = kwargs.pop('prefix', self.Meta.model.__name__)
-    #    super(NewSwitchForm, self).__init__(*args, prefix=prefix, **kwargs)
-    #    self.fields['location'].label = 'Localisation'
-    #    self.fields['number'].label = 'Nombre de ports'
 
 class EditRoomForm(ModelForm):
     """Permet d'éediter le nom et commentaire d'une prise murale"""
diff --git a/topologie/models.py b/topologie/models.py
index ca5c7093..e0891f18 100644
--- a/topologie/models.py
+++ b/topologie/models.py
@@ -190,7 +190,7 @@ class Switch(Interface):
     class Meta:
         unique_together = ('stack', 'stack_member_id')
         permissions = (
-            ("view_newswitch", "Peut voir un objet switch"),
+            ("view_switch", "Peut voir un objet switch"),
         )
 
     def get_instance(switch_id, *args, **kwargs):
@@ -220,11 +220,10 @@ class Switch(Interface):
             return False, u"Vous n'avez pas le droit de voir les switch"
         return True, None
  
-#    def __str__(self):
-#        return self.location + ' ' + str(self.switch_interface)
-
     def clean(self):
-        """ Verifie que l'id stack est dans le bon range"""
+        """ Verifie que l'id stack est dans le bon range
+        Appelle également le clean de la classe parente"""
+        super(Switch, self).clean()
         if self.stack is not None:
             if self.stack_member_id is not None:
                 if (self.stack_member_id > self.stack.member_id_max) or\

From 81ec19ecce8d26eb3db31f9381e3dc3c8fbe320a Mon Sep 17 00:00:00 2001
From: Gabriel Detraz <detraz@crans.org>
Date: Sun, 25 Mar 2018 16:22:50 +0200
Subject: [PATCH 15/26] Del code mort

---
 logs/views.py | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/logs/views.py b/logs/views.py
index f40ca3fc..b3af50e9 100644
--- a/logs/views.py
+++ b/logs/views.py
@@ -459,14 +459,5 @@ def stats_droits(request):
     
     for droit in ListRight.objects.all().select_related('group_ptr'):#.prefetch_related('group_ptr__user_set__revision_set'):
         stats_list[droit]=droit.user_set.all().annotate(num=Count('revision'),last=Max('revision__date_created'))
-    
-    # count,last=0,0
-    # for droit in ListRight.objects.all():
-    #     for use in droit.user_set.all():
-    #         countRevision.objects.filter(user=use).count()
-    #         print(Revision.objects.order_by('date_created').last().date_created)
-    #     stats_list[droit]=use.annotate(num=count,las)
-
-    #raise ValueError('temps='+str(time()-depart))
 
     return render(request, 'logs/stats_droits.html', {'stats_list': stats_list})

From 3b18d308be27ce158e007fd199217a1b42836771 Mon Sep 17 00:00:00 2001
From: Gabriel Detraz <detraz@crans.org>
Date: Sun, 25 Mar 2018 18:31:50 +0200
Subject: [PATCH 16/26] Adapte auth.py pour la nouvelle gestion switchs

---
 freeradius_utils/auth.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/freeradius_utils/auth.py b/freeradius_utils/auth.py
index 823d0d58..17b9513d 100644
--- a/freeradius_utils/auth.py
+++ b/freeradius_utils/auth.py
@@ -301,7 +301,7 @@ def decide_vlan_and_register_switch(nas, nas_type, port_number, mac_address):
 
     sw_name = str(nas)
 
-    port = Port.objects.filter(switch=Switch.objects.filter(switch_interface=nas), port=port_number).first()
+    port = Port.objects.filter(switch=Switch.objects.filter(interface_ptr=nas), port=port_number).first()
     #Si le port est inconnu, on place sur le vlan defaut
     if not port:
         return (sw_name, "Chambre inconnue", u'Port inconnu', VLAN_OK)

From a0afb3e5b41ba152754f09215ac04ab3760aafeb Mon Sep 17 00:00:00 2001
From: Gabriel Detraz <detraz@crans.org>
Date: Sun, 25 Mar 2018 18:48:45 +0200
Subject: [PATCH 17/26] =?UTF-8?q?Switch=20etant=20une=20instance=20interfa?=
 =?UTF-8?q?ce,=20inutile=20de=20faire=20cette=20requ=C3=A8te?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 freeradius_utils/auth.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/freeradius_utils/auth.py b/freeradius_utils/auth.py
index 17b9513d..4ab45b25 100644
--- a/freeradius_utils/auth.py
+++ b/freeradius_utils/auth.py
@@ -201,7 +201,7 @@ def post_auth(data):
         if instance_stack:
             # Si c'est le cas, on resélectionne le bon switch dans la stack
             id_stack_member = port.split("-")[1].split('/')[0]
-            nas_instance = Interface.objects.filter(switch__in=Switch.objects.filter(stack=instance_stack).filter(stack_member_id=id_stack_member)).select_related('domain__extension').first()
+            nas_instance = Switch.objects.filter(stack=instance_stack).filter(stack_member_id=id_stack_member).select_related('domain__extension').first()
         # On récupère le numéro du port sur l'output de freeradius. La ligne suivante fonctionne pour cisco, HP et Juniper
         port = port.split(".")[0].split('/')[-1][-2:]
         out = decide_vlan_and_register_switch(nas_instance, nas_type, port, mac)

From 50d04b0ae2623adc7c1af7df5e2ef893de877aa7 Mon Sep 17 00:00:00 2001
From: Gabriel Detraz <detraz@crans.org>
Date: Sun, 25 Mar 2018 23:01:06 +0200
Subject: [PATCH 18/26] Fix divers

---
 logs/views.py   | 5 ++---
 search/views.py | 6 +++---
 users/views.py  | 6 ++----
 3 files changed, 7 insertions(+), 10 deletions(-)

diff --git a/logs/views.py b/logs/views.py
index b3af50e9..6ab48706 100644
--- a/logs/views.py
+++ b/logs/views.py
@@ -42,8 +42,7 @@ from django.shortcuts import render, redirect
 from django.core.paginator import Paginator, EmptyPage, PageNotAnInteger
 from django.contrib import messages
 from django.contrib.auth.decorators import login_required
-from django.db.models import Count
-from django.db.models import Max
+from django.db.models import Count, Max
 
 from reversion.models import Revision
 from reversion.models import Version, ContentType
@@ -457,7 +456,7 @@ def stats_droits(request):
     depart=time()
     stats_list={}
     
-    for droit in ListRight.objects.all().select_related('group_ptr'):#.prefetch_related('group_ptr__user_set__revision_set'):
+    for droit in ListRight.objects.all().select_related('group_ptr'):
         stats_list[droit]=droit.user_set.all().annotate(num=Count('revision'),last=Max('revision__date_created'))
 
     return render(request, 'logs/stats_droits.html', {'stats_list': stats_list})
diff --git a/search/views.py b/search/views.py
index 601f4eeb..21279bfa 100644
--- a/search/views.py
+++ b/search/views.py
@@ -260,7 +260,7 @@ def search_single_word(word, filters, user,
         ) | Q(
             machine_interface__domain__name__icontains=word
         ) | Q(
-            related__switch__switch_interface__domain__name__icontains=word
+            related__switch__domain__name__icontains=word
         ) | Q(
             radius__icontains=word
         ) | Q(
@@ -277,9 +277,9 @@ def search_single_word(word, filters, user,
     # Switches
     if '7' in aff and Switch.can_view_all(user):
         filter_switches = Q(
-            switch_interface__domain__name__icontains=word
+            domain__name__icontains=word
         ) | Q(
-            switch_interface__ipv4__ipv4__icontains=word
+            ipv4__ipv4__icontains=word
         ) | Q(
             location__icontains=word
         ) | Q(
diff --git a/users/views.py b/users/views.py
index a6a28ed0..a0d46fe8 100644
--- a/users/views.py
+++ b/users/views.py
@@ -501,8 +501,7 @@ def del_school(request, instances):
 @login_required
 @can_create(ListShell)
 def add_shell(request):
-    """ Ajouter un établissement d'enseignement à la base de donnée,
-    need cableur"""
+    """ Ajouter un shell à la base de donnée"""
     shell = ShellForm(request.POST or None)
     if shell.is_valid():
         with transaction.atomic(), reversion.create_revision():
@@ -517,8 +516,7 @@ def add_shell(request):
 @login_required
 @can_edit(ListShell)
 def edit_shell(request, shell_instance, shellid):
-    """ Editer un établissement d'enseignement à partir du shellid dans
-    la base de donnée, need cableur"""
+    """ Editer un shell à partir du shellid"""
     shell = ShellForm(request.POST or None, instance=shell_instance)
     if shell.is_valid():
         with transaction.atomic(), reversion.create_revision():

From 297e300abe8839307516c76de8722cc33f19358a Mon Sep 17 00:00:00 2001
From: Gabriel Detraz <detraz@crans.org>
Date: Mon, 26 Mar 2018 00:08:24 +0200
Subject: [PATCH 19/26] Rename Borne en AccessPoint

---
 re2o/templatetags/acl.py                      |  1 +
 re2o/utils.py                                 |  6 +-
 re2o/views.py                                 |  2 +-
 topologie/admin.py                            |  6 +-
 topologie/forms.py                            | 10 +--
 .../migrations/0044_auto_20180326_0002.py     | 28 +++++++
 topologie/models.py                           | 18 ++--
 topologie/templates/topologie/aff_ap.html     | 74 +++++++++++++++++
 topologie/templates/topologie/aff_borne.html  | 74 -----------------
 .../{index_borne.html => index_ap.html}       |  6 +-
 topologie/templates/topologie/sidebar.html    |  2 +-
 topologie/urls.py                             | 10 +--
 topologie/views.py                            | 82 +++++++++----------
 13 files changed, 174 insertions(+), 145 deletions(-)
 create mode 100644 topologie/migrations/0044_auto_20180326_0002.py
 create mode 100644 topologie/templates/topologie/aff_ap.html
 delete mode 100644 topologie/templates/topologie/aff_borne.html
 rename topologie/templates/topologie/{index_borne.html => index_ap.html} (88%)

diff --git a/re2o/templatetags/acl.py b/re2o/templatetags/acl.py
index c2d3ba24..d749b299 100644
--- a/re2o/templatetags/acl.py
+++ b/re2o/templatetags/acl.py
@@ -122,6 +122,7 @@ MODEL_NAME = {
     # topologie
     'Stack' : topologie.models.Stack,
     'Switch' : topologie.models.Switch,
+    'AccessPoint' : topologie.models.AccessPoint,
     'ModelSwitch' : topologie.models.ModelSwitch,
     'ConstructorSwitch' : topologie.models.ConstructorSwitch,
     'Port' : topologie.models.Port,
diff --git a/re2o/utils.py b/re2o/utils.py
index d577ba70..a3c1dcb8 100644
--- a/re2o/utils.py
+++ b/re2o/utils.py
@@ -234,9 +234,9 @@ class SortTable:
         'default': ['name']
     }
     TOPOLOGIE_INDEX_BORNE = {
-        'borne_name': ['domain__name'],
-        'borne_ip': ['ipv4__ipv4'],
-        'borne_mac': ['mac_address'],
+        'ap_name': ['domain__name'],
+        'ap_ip': ['ipv4__ipv4'],
+        'ap_mac': ['mac_address'],
         'default': ['domain__name']
     }
     TOPOLOGIE_INDEX_STACK = {
diff --git a/re2o/views.py b/re2o/views.py
index c0fbb8ef..9a987e5a 100644
--- a/re2o/views.py
+++ b/re2o/views.py
@@ -83,7 +83,7 @@ HISTORY_BIND = {
         'stack' : topologie.models.Stack,
         'model_switch' : topologie.models.ModelSwitch,
         'constructor_switch' : topologie.models.ConstructorSwitch,
-        'borne' : topologie.models.Borne,
+        'ap' : topologie.models.AccessPoint,
     },
     'machines' : {
         'machine' : machines.models.Machine,
diff --git a/topologie/admin.py b/topologie/admin.py
index f7021148..6c64aec7 100644
--- a/topologie/admin.py
+++ b/topologie/admin.py
@@ -36,7 +36,7 @@ from .models import (
     Stack,
     ModelSwitch,
     ConstructorSwitch,
-    Borne
+    AccessPoint
 )
 
 
@@ -55,7 +55,7 @@ class PortAdmin(VersionAdmin):
     pass
 
 
-class BorneAdmin(VersionAdmin):
+class AccessPointAdmin(VersionAdmin):
     """Administration d'une borne"""
     pass
 
@@ -76,7 +76,7 @@ class ConstructorSwitchAdmin(VersionAdmin):
 
 
 admin.site.register(Port, PortAdmin)
-admin.site.register(Borne, BorneAdmin)
+admin.site.register(AccessPoint, AccessPointAdmin)
 admin.site.register(Room, RoomAdmin)
 admin.site.register(Switch, SwitchAdmin)
 admin.site.register(Stack, StackAdmin)
diff --git a/topologie/forms.py b/topologie/forms.py
index 6e37bb0c..568ddd74 100644
--- a/topologie/forms.py
+++ b/topologie/forms.py
@@ -43,7 +43,7 @@ from .models import (
     Stack,
     ModelSwitch,
     ConstructorSwitch,
-    Borne
+    AccessPoint
 )
 
 
@@ -111,18 +111,18 @@ class StackForm(ModelForm):
         super(StackForm, self).__init__(*args, prefix=prefix, **kwargs)
 
 
-class AddBorneForm(EditInterfaceForm):
+class AddAccessPointForm(EditInterfaceForm):
     """Formulaire pour la création d'une borne
     Relié directement au modèle borne"""
     class Meta:
-        model = Borne
+        model = AccessPoint
         fields = ['mac_address', 'type', 'ipv4', 'details', 'location']
 
 
-class EditBorneForm(EditInterfaceForm):
+class EditAccessPointForm(EditInterfaceForm):
     """Edition d'une interface. Edition complète"""
     class Meta:
-        model = Borne
+        model = AccessPoint
         fields = ['machine', 'type', 'ipv4', 'mac_address', 'details', 'location']
 
 
diff --git a/topologie/migrations/0044_auto_20180326_0002.py b/topologie/migrations/0044_auto_20180326_0002.py
new file mode 100644
index 00000000..f18b4ed9
--- /dev/null
+++ b/topologie/migrations/0044_auto_20180326_0002.py
@@ -0,0 +1,28 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.7 on 2018-03-25 22:02
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('topologie', '0043_renamenewswitch'),
+    ]
+
+    operations = [
+        migrations.RenameModel(
+            old_name='Borne',
+            new_name='AccessPoint',
+        ),
+        migrations.AlterModelOptions(
+            name='accesspoint',
+            options={'permissions': (('view_ap', 'Peut voir une borne'),)},
+        ),
+        migrations.AlterModelOptions(
+            name='switch',
+            options={'permissions': (('view_switch', 'Peut voir un objet switch'),)},
+        ),
+    ]
diff --git a/topologie/models.py b/topologie/models.py
index e0891f18..d94c5704 100644
--- a/topologie/models.py
+++ b/topologie/models.py
@@ -109,7 +109,7 @@ class Stack(models.Model):
                 inférieure à l'id minimale"})
 
 
-class Borne(Interface):
+class AccessPoint(Interface):
     """Define a wireless AP. Inherit from machines.interfaces
     
     Definition pour une borne wifi , hérite de machines.interfaces
@@ -125,33 +125,33 @@ class Borne(Interface):
 
     class Meta:
         permissions = (
-            ("view_borne", "Peut voir une borne"),
+            ("view_ap", "Peut voir une borne"),
         )
 
-    def get_instance(borne_id, *args, **kwargs):
-        return Borne.objects.get(pk=borne_id)
+    def get_instance(ap_id, *args, **kwargs):
+        return AccessPoint.objects.get(pk=ap_id)
 
     def can_create(user_request, *args, **kwargs):
-        return user_request.has_perm('topologie.add_borne') , u"Vous n'avez pas le droit\
+        return user_request.has_perm('topologie.add_ap') , u"Vous n'avez pas le droit\
             de créer une borne"
 
     def can_edit(self, user_request, *args, **kwargs):
-        if not user_request.has_perm('topologie.change_borne'):
+        if not user_request.has_perm('topologie.change_ap'):
             return False, u"Vous n'avez pas le droit d'éditer des bornes"
         return True, None
 
     def can_delete(self, user_request, *args, **kwargs):
-        if not user_request.has_perm('topologie.delete_borne'):
+        if not user_request.has_perm('topologie.delete_ap'):
             return False, u"Vous n'avez pas le droit de supprimer une borne"
         return True, None
 
     def can_view_all(user_request, *args, **kwargs):
-        if not user_request.has_perm('topologie.view_borne'):
+        if not user_request.has_perm('topologie.view_ap'):
             return False, u"Vous n'avez pas le droit de voir les bornes"
         return True, None
 
     def can_view(self, user_request, *args, **kwargs):
-        if not user_request.has_perm('topologie.view_borne'):
+        if not user_request.has_perm('topologie.view_ap'):
             return False, u"Vous n'avez pas le droit de voir les bornes"
         return True, None
 
diff --git a/topologie/templates/topologie/aff_ap.html b/topologie/templates/topologie/aff_ap.html
new file mode 100644
index 00000000..b9130a0d
--- /dev/null
+++ b/topologie/templates/topologie/aff_ap.html
@@ -0,0 +1,74 @@
+{% comment %}
+Re2o est un logiciel d'administration développé initiallement au rezometz. Il
+se veut agnostique au réseau considéré, de manière à être installable en
+quelques clics.
+
+Copyright © 2017  Gabriel Détraz
+Copyright © 2017  Goulven Kermarec
+Copyright © 2017  Augustin Lemesle
+
+This program is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 2 of the License, or
+(at your option) any later version.
+
+This program is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License along
+with this program; if not, write to the Free Software Foundation, Inc.,
+51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+{% endcomment %}
+
+{% load acl %}
+
+<div class="table-responsive">
+	{% if ap_list.paginator %}
+	{% include "pagination.html" with list=ap_list %}
+	{% endif %}
+
+
+	<table class="table table-striped">
+		<thead>
+			<tr>
+				<th>{% include "buttons/sort.html" with prefix='ap' col='name' text='Borne' %}</th>
+				<th>{% include "buttons/sort.html" with prefix='ap' col='mac' text='Addresse mac' %}</th>
+				<th>{% include "buttons/sort.html" with prefix='ap' col='ip' text='Ipv4' %}</th>
+				<th>Commentaire</th>
+				<th>Localisation</th> 
+				<th></th>
+			</tr>
+		</thead>
+		{% for ap in ap_list %}
+		<tr>
+			<td>{{ap}}</td>
+			<td>{{ap.mac_address}}</td>
+			<td>{{ap.ipv4}}</td>
+			<td>{{ap.details}}</td>
+			<td>{{ap.location}}</td>
+			<td class="text-right">
+				<a class="btn btn-info btn-sm" role="button" title="Historique" href="{% url 'topologie:history' 'ap' ap.pk %}">
+					<i class="fa fa-history"></i>
+				</a>
+				{% can_edit ap %}
+				<a class="btn btn-primary btn-sm" role="button" title="Éditer" href="{% url 'topologie:edit-ap' ap.id %}">
+					<i class="fa fa-edit"></i>
+				</a>
+				{% acl_end %}
+				{% can_delete ap %}
+				<a class="btn btn-danger btn-sm" role="button" title="Supprimer" href="{% url 'machines:del-interface' ap.id %}">
+					<i class="fa fa-trash"></i>
+				</a>
+				{% acl_end %}
+			</td>
+		</tr>
+		{% endfor %}
+	</table>
+
+
+	{% if ap_list.paginator %}
+{% include "pagination.html" with list=ap_list %}
+{% endif %}
+</div>
diff --git a/topologie/templates/topologie/aff_borne.html b/topologie/templates/topologie/aff_borne.html
deleted file mode 100644
index 8080aaaf..00000000
--- a/topologie/templates/topologie/aff_borne.html
+++ /dev/null
@@ -1,74 +0,0 @@
-{% comment %}
-Re2o est un logiciel d'administration développé initiallement au rezometz. Il
-se veut agnostique au réseau considéré, de manière à être installable en
-quelques clics.
-
-Copyright © 2017  Gabriel Détraz
-Copyright © 2017  Goulven Kermarec
-Copyright © 2017  Augustin Lemesle
-
-This program is free software; you can redistribute it and/or modify
-it under the terms of the GNU General Public License as published by
-the Free Software Foundation; either version 2 of the License, or
-(at your option) any later version.
-
-This program is distributed in the hope that it will be useful,
-but WITHOUT ANY WARRANTY; without even the implied warranty of
-MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-GNU General Public License for more details.
-
-You should have received a copy of the GNU General Public License along
-with this program; if not, write to the Free Software Foundation, Inc.,
-51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
-{% endcomment %}
-
-{% load acl %}
-
-<div class="table-responsive">
-{% if borne_list.paginator %}
-{% include "pagination.html" with list=borne_list %}
-{% endif %}
-
-
-<table class="table table-striped">
-    <thead>
-        <tr>
-            <th>{% include "buttons/sort.html" with prefix='borne' col='name' text='Borne' %}</th>
-	    <th>{% include "buttons/sort.html" with prefix='borne' col='mac' text='Addresse mac' %}</th>
-	    <th>{% include "buttons/sort.html" with prefix='borne' col='ip' text='Ipv4' %}</th>
-	    <th>Commentaire</th>
-            <th>Localisation</th> 
-	    <th></th>
-        </tr>
-   </thead>
-   {% for borne in borne_list %}
-   <tr>
-       <td>{{borne}}</td>
-       <td>{{borne.mac_address}}</td>
-       <td>{{borne.ipv4}}</td>
-       <td>{{borne.details}}</td>
-       <td>{{borne.location}}</td>
-        <td class="text-right">
-            <a class="btn btn-info btn-sm" role="button" title="Historique" href="{% url 'topologie:history' 'borne' borne.pk %}">
-                <i class="fa fa-history"></i>
-            </a>
-        {% can_edit borne %}
-            <a class="btn btn-primary btn-sm" role="button" title="Éditer" href="{% url 'topologie:edit-borne' borne.id %}">
-                <i class="fa fa-edit"></i>
-            </a>
-	{% acl_end %}
-	{% can_delete borne %}
-            <a class="btn btn-danger btn-sm" role="button" title="Supprimer" href="{% url 'machines:del-interface' borne.id %}">
-                <i class="fa fa-trash"></i>
-            </a>
-        {% acl_end %}
-        </td>
-   </tr>
-   {% endfor %}
-</table>
-
-
-{% if borne_list.paginator %}
-{% include "pagination.html" with list=borne_list %}
-{% endif %}
-</div>
diff --git a/topologie/templates/topologie/index_borne.html b/topologie/templates/topologie/index_ap.html
similarity index 88%
rename from topologie/templates/topologie/index_borne.html
rename to topologie/templates/topologie/index_ap.html
index e6d20dfb..19499998 100644
--- a/topologie/templates/topologie/index_borne.html
+++ b/topologie/templates/topologie/index_ap.html
@@ -30,11 +30,11 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 
 {% block content %}
   <h2>Points d'accès WiFi</h2>
-{% can_create Room %}
-<a class="btn btn-primary btn-sm" role="button" href="{% url 'topologie:new-borne' %}"><i class="fa fa-plus"></i> Ajouter une borne</a>
+{% can_create AccessPoint %}
+<a class="btn btn-primary btn-sm" role="button" href="{% url 'topologie:new-ap' %}"><i class="fa fa-plus"></i> Ajouter une borne</a>
 <hr>
 {% acl_end %}
-    {% include "topologie/aff_borne.html" with borne_list=borne_list %}
+    {% include "topologie/aff_ap.html" with ap_list=ap_list %}
     <br />
     <br />
     <br />
diff --git a/topologie/templates/topologie/sidebar.html b/topologie/templates/topologie/sidebar.html
index 6351ffd0..bdbcf7fc 100644
--- a/topologie/templates/topologie/sidebar.html
+++ b/topologie/templates/topologie/sidebar.html
@@ -33,7 +33,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
         <i class="fa fa-microchip"></i>
         Switchs
     </a>
-     <a class="list-group-item list-group-item-info" href="{% url "topologie:index-borne" %}">
+     <a class="list-group-item list-group-item-info" href="{% url "topologie:index-ap" %}">
         <i class="fa fa-wifi"></i>
         Bornes WiFi
     </a>
diff --git a/topologie/urls.py b/topologie/urls.py
index 19b87947..1f2968b7 100644
--- a/topologie/urls.py
+++ b/topologie/urls.py
@@ -35,11 +35,11 @@ from . import views
 
 urlpatterns = [
     url(r'^$', views.index, name='index'),
-    url(r'^index_borne/$', views.index_borne, name='index-borne'),
-    url(r'^new_borne/$', views.new_borne, name='new-borne'),
-    url(r'^edit_borne/(?P<borne_id>[0-9]+)$',
-        views.edit_borne,
-        name='edit-borne'),
+    url(r'^index_ap/$', views.index_ap, name='index-ap'),
+    url(r'^new_ap/$', views.new_ap, name='new-ap'),
+    url(r'^edit_ap/(?P<ap_id>[0-9]+)$',
+        views.edit_ap,
+        name='edit-ap'),
     url(r'^create_ports/(?P<switch_id>[0-9]+)$',
         views.create_ports,
         name='create-ports'),
diff --git a/topologie/views.py b/topologie/views.py
index 97091a83..6102bb66 100644
--- a/topologie/views.py
+++ b/topologie/views.py
@@ -54,7 +54,7 @@ from topologie.models import (
     Stack,
     ModelSwitch,
     ConstructorSwitch,
-    Borne
+    AccessPoint
 )
 from topologie.forms import EditPortForm, NewSwitchForm, EditSwitchForm
 from topologie.forms import (
@@ -64,8 +64,8 @@ from topologie.forms import (
     EditModelSwitchForm,
     EditConstructorSwitchForm,
     CreatePortsForm,
-    AddBorneForm,
-    EditBorneForm
+    AddAccessPointForm,
+    EditAccessPointForm
 )
 from users.views import form
 from re2o.utils import SortTable
@@ -172,29 +172,29 @@ def index_room(request):
 
 
 @login_required
-@can_view_all(Borne)
-def index_borne(request):
+@can_view_all(AccessPoint)
+def index_ap(request):
     """ Affichage de l'ensemble des bornes"""
-    borne_list = Borne.objects
-    borne_list = SortTable.sort(
-        borne_list,
+    ap_list = AccessPoint.objects
+    ap_list = SortTable.sort(
+        ap_list,
         request.GET.get('col'),
         request.GET.get('order'),
         SortTable.TOPOLOGIE_INDEX_BORNE
     )
     pagination_number = GeneralOption.get_cached_value('pagination_number')
-    paginator = Paginator(borne_list, pagination_number)
+    paginator = Paginator(ap_list, pagination_number)
     page = request.GET.get('page')
     try:
-        borne_list = paginator.page(page)
+        ap_list = paginator.page(page)
     except PageNotAnInteger:
         # If page is not an integer, deliver first page.
-        borne_list = paginator.page(1)
+        ap_list = paginator.page(1)
     except EmptyPage:
         # If page is out of range (e.g. 9999), deliver last page of results.
-        borne_list = paginator.page(paginator.num_pages)
-    return render(request, 'topologie/index_borne.html', {
-        'borne_list': borne_list
+        ap_list = paginator.page(paginator.num_pages)
+    return render(request, 'topologie/index_ap.html', {
+        'ap_list': ap_list
         })
 
 
@@ -526,12 +526,12 @@ def edit_switch(request, switch, switch_id):
 
 
 @login_required
-@can_create(Borne)
-def new_borne(request):
-    """ Creation d'une borne. Cree en meme temps l'interface et la machine
+@can_create(AccessPoint)
+def new_ap(request):
+    """ Creation d'une ap. Cree en meme temps l'interface et la machine
     associée. Vue complexe. Appelle successivement les 3 models forms
     adaptés : machine, interface, domain et switch"""
-    borne = AddBorneForm(
+    ap = AddAccessPointForm(
         request.POST or None,
         user=request.user
     )
@@ -542,7 +542,7 @@ def new_borne(request):
     domain = DomainForm(
         request.POST or None,
         )
-    if borne.is_valid() and machine.is_valid():
+    if ap.is_valid() and machine.is_valid():
         user = AssoOption.get_cached_value('utilisateur_asso')
         if not user:
             messages.error(request, "L'user association n'existe pas encore,\
@@ -550,29 +550,29 @@ def new_borne(request):
             return redirect(reverse('topologie:index'))
         new_machine = machine.save(commit=False)
         new_machine.user = user
-        new_borne = borne.save(commit=False)
-        domain.instance.interface_parent = new_borne
+        new_ap = ap.save(commit=False)
+        domain.instance.interface_parent = new_ap
         if domain.is_valid():
             new_domain_instance = domain.save(commit=False)
             with transaction.atomic(), reversion.create_revision():
                 new_machine.save()
                 reversion.set_user(request.user)
                 reversion.set_comment("Création")
-            new_borne.machine = new_machine
+            new_ap.machine = new_machine
             with transaction.atomic(), reversion.create_revision():
-                new_borne.save()
+                new_ap.save()
                 reversion.set_user(request.user)
                 reversion.set_comment("Création")
-            new_domain_instance.interface_parent = new_borne
+            new_domain_instance.interface_parent = new_ap
             with transaction.atomic(), reversion.create_revision():
                 new_domain_instance.save()
                 reversion.set_user(request.user)
                 reversion.set_comment("Création")
             messages.success(request, "La borne a été créé")
-            return redirect(reverse('topologie:index-borne'))
-    i_mbf_param = generate_ipv4_mbf_param(borne, False)
+            return redirect(reverse('topologie:index-ap'))
+    i_mbf_param = generate_ipv4_mbf_param(ap, False)
     return form({
-        'topoform': borne,
+        'topoform': ap,
         'machineform': machine,
         'domainform': domain,
         'i_mbf_param': i_mbf_param,
@@ -581,32 +581,32 @@ def new_borne(request):
 
 
 @login_required
-@can_edit(Borne)
-def edit_borne(request, borne, borne_id):
+@can_edit(AccessPoint)
+def edit_ap(request, ap, ap_id):
     """ Edition d'un switch. Permet de chambre nombre de ports,
     place dans le stack, interface et machine associée"""
-    borne_form = EditBorneForm(
+    ap_form = EditAccessPointForm(
         request.POST or None,
         user=request.user,
-        instance=borne
+        instance=ap
     )
     machine_form = NewMachineForm(
         request.POST or None,
         user=request.user,
-        instance=borne.machine
+        instance=ap.machine
     )
     domain_form = DomainForm(
         request.POST or None,
-        instance=borne.domain
+        instance=ap.domain
         )
-    if borne_form.is_valid() and machine_form.is_valid():
+    if ap_form.is_valid() and machine_form.is_valid():
         user = AssoOption.get_cached_value('utilisateur_asso')
         if not user:
             messages.error(request, "L'user association n'existe pas encore,\
             veuillez le créer ou le linker dans preferences")
-            return redirect(reverse('topologie:index-borne'))
+            return redirect(reverse('topologie:index-ap'))
         new_machine = machine_form.save(commit=False)
-        new_borne = borne_form.save(commit=False)
+        new_ap = ap_form.save(commit=False)
         new_domain = domain_form.save(commit=False)
         with transaction.atomic(), reversion.create_revision():
             new_machine.save()
@@ -616,10 +616,10 @@ def edit_borne(request, borne, borne_id):
                     field for field in machine_form.changed_data)
             )
         with transaction.atomic(), reversion.create_revision():
-            new_borne.save()
+            new_ap.save()
             reversion.set_user(request.user)
             reversion.set_comment("Champs modifié(s) : %s" % ', '.join(
-                field for field in borne_form.changed_data)
+                field for field in ap_form.changed_data)
             )
             reversion.set_comment("Création")
         with transaction.atomic(), reversion.create_revision():
@@ -629,10 +629,10 @@ def edit_borne(request, borne, borne_id):
                 field for field in domain_form.changed_data)
             )
         messages.success(request, "La borne a été modifiée")
-        return redirect(reverse('topologie:index-borne'))
-    i_mbf_param = generate_ipv4_mbf_param(borne_form, False )
+        return redirect(reverse('topologie:index-ap'))
+    i_mbf_param = generate_ipv4_mbf_param(ap_form, False )
     return form({
-        'topoform': borne_form,
+        'topoform': ap_form,
         'machineform': machine_form,
         'domainform': domain_form,
         'i_mbf_param': i_mbf_param,

From 43ff16ccb92f9a4e3e897d57a7b72127c72a6a9f Mon Sep 17 00:00:00 2001
From: Gabriel Detraz <detraz@crans.org>
Date: Mon, 26 Mar 2018 01:41:49 +0200
Subject: [PATCH 20/26] =?UTF-8?q?Migrations=20switchs=20compl=C3=A9mentair?=
 =?UTF-8?q?es?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 topologie/migrations/0041_transferportsw.py   |  4 ++++
 .../migrations/0045_auto_20180326_0123.py     | 21 +++++++++++++++++++
 .../migrations/0046_auto_20180326_0129.py     | 19 +++++++++++++++++
 3 files changed, 44 insertions(+)
 create mode 100644 topologie/migrations/0045_auto_20180326_0123.py
 create mode 100644 topologie/migrations/0046_auto_20180326_0129.py

diff --git a/topologie/migrations/0041_transferportsw.py b/topologie/migrations/0041_transferportsw.py
index a629c7e6..9e1d979a 100644
--- a/topologie/migrations/0041_transferportsw.py
+++ b/topologie/migrations/0041_transferportsw.py
@@ -12,6 +12,10 @@ class Migration(migrations.Migration):
     ]
 
     operations = [
+    migrations.AlterUniqueTogether(
+        name='port',
+        unique_together=set([]),
+    ),
     migrations.RemoveField(
         model_name='port',
         name='switch',
diff --git a/topologie/migrations/0045_auto_20180326_0123.py b/topologie/migrations/0045_auto_20180326_0123.py
new file mode 100644
index 00000000..cf621967
--- /dev/null
+++ b/topologie/migrations/0045_auto_20180326_0123.py
@@ -0,0 +1,21 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.7 on 2018-03-25 23:23
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('topologie', '0044_auto_20180326_0002'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='port',
+            name='switch',
+            field=models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='ports', to='topologie.Switch'),
+        ),
+    ]
diff --git a/topologie/migrations/0046_auto_20180326_0129.py b/topologie/migrations/0046_auto_20180326_0129.py
new file mode 100644
index 00000000..dc5e849e
--- /dev/null
+++ b/topologie/migrations/0046_auto_20180326_0129.py
@@ -0,0 +1,19 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.7 on 2018-03-25 23:29
+from __future__ import unicode_literals
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('topologie', '0045_auto_20180326_0123'),
+    ]
+
+    operations = [
+        migrations.AlterUniqueTogether(
+            name='port',
+            unique_together=set([('switch', 'port')]),
+        ),
+    ]

From 119416cc4fcfc460975269e6f3f604aa490f7192 Mon Sep 17 00:00:00 2001
From: Gabriel Detraz <detraz@crans.org>
Date: Mon, 26 Mar 2018 03:09:42 +0200
Subject: [PATCH 21/26] =?UTF-8?q?Bornes=20h=C3=A9rite=20de=20machine?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 re2o/utils.py                             |  8 +--
 topologie/forms.py                        | 16 +++---
 topologie/migrations/0047_ap_machine.py   | 26 +++++++++
 topologie/migrations/0048_ap_machine.py   | 39 ++++++++++++++
 topologie/models.py                       |  4 +-
 topologie/templates/topologie/aff_ap.html | 10 ++--
 topologie/views.py                        | 66 +++++++++++------------
 7 files changed, 119 insertions(+), 50 deletions(-)
 create mode 100644 topologie/migrations/0047_ap_machine.py
 create mode 100644 topologie/migrations/0048_ap_machine.py

diff --git a/re2o/utils.py b/re2o/utils.py
index a3c1dcb8..fcb4f8a8 100644
--- a/re2o/utils.py
+++ b/re2o/utils.py
@@ -234,10 +234,10 @@ class SortTable:
         'default': ['name']
     }
     TOPOLOGIE_INDEX_BORNE = {
-        'ap_name': ['domain__name'],
-        'ap_ip': ['ipv4__ipv4'],
-        'ap_mac': ['mac_address'],
-        'default': ['domain__name']
+        'ap_name': ['interface__domain__name'],
+        'ap_ip': ['interface__ipv4__ipv4'],
+        'ap_mac': ['interface__mac_address'],
+        'default': ['interface__domain__name']
     }
     TOPOLOGIE_INDEX_STACK = {
         'stack_name': ['name'],
diff --git a/topologie/forms.py b/topologie/forms.py
index 568ddd74..5032d15e 100644
--- a/topologie/forms.py
+++ b/topologie/forms.py
@@ -33,7 +33,11 @@ NewSwitchForm)
 from __future__ import unicode_literals
 
 from machines.models import Interface
-from machines.forms import EditInterfaceForm
+from machines.forms import (
+    EditInterfaceForm,
+    EditMachineForm,
+    NewMachineForm
+)
 from django import forms
 from django.forms import ModelForm, Form
 from .models import ( 
@@ -111,19 +115,19 @@ class StackForm(ModelForm):
         super(StackForm, self).__init__(*args, prefix=prefix, **kwargs)
 
 
-class AddAccessPointForm(EditInterfaceForm):
+class AddAccessPointForm(NewMachineForm):
     """Formulaire pour la création d'une borne
     Relié directement au modèle borne"""
     class Meta:
         model = AccessPoint
-        fields = ['mac_address', 'type', 'ipv4', 'details', 'location']
+        fields = ['location', 'name']
 
 
-class EditAccessPointForm(EditInterfaceForm):
-    """Edition d'une interface. Edition complète"""
+class EditAccessPointForm(EditMachineForm):
+    """Edition d'une borne. Edition complète"""
     class Meta:
         model = AccessPoint
-        fields = ['machine', 'type', 'ipv4', 'mac_address', 'details', 'location']
+        fields = '__all__'
 
 
 class EditSwitchForm(EditInterfaceForm):
diff --git a/topologie/migrations/0047_ap_machine.py b/topologie/migrations/0047_ap_machine.py
new file mode 100644
index 00000000..f09ca318
--- /dev/null
+++ b/topologie/migrations/0047_ap_machine.py
@@ -0,0 +1,26 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.7 on 2018-03-23 01:18
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('topologie', '0046_auto_20180326_0129'),
+    ]
+
+
+
+    operations = [
+        migrations.CreateModel(
+            name='NewAccessPoint',
+            fields=[
+                ('machine_ptr', models.OneToOneField(auto_created=True, on_delete=django.db.models.deletion.CASCADE, parent_link=True, primary_key=True, serialize=False, to='machines.Machine')),
+                ('location', models.CharField(help_text="Détails sur la localisation de l'AP", max_length=255, null=True, blank=True)),
+            ],
+            bases=('machines.machine',),
+        ),
+    ]
diff --git a/topologie/migrations/0048_ap_machine.py b/topologie/migrations/0048_ap_machine.py
new file mode 100644
index 00000000..ed1aa2fd
--- /dev/null
+++ b/topologie/migrations/0048_ap_machine.py
@@ -0,0 +1,39 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.7 on 2018-03-23 01:18
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('topologie', '0047_ap_machine'),
+    ]
+
+    def transfer_ap(apps, schema_editor):
+        db_alias = schema_editor.connection.alias
+        ap = apps.get_model("topologie", "AccessPoint")
+        new_ap = apps.get_model("topologie", "NewAccessPoint")
+        ap_list = ap.objects.using(db_alias).all()
+        for borne in ap_list:
+            new_borne = new_ap()
+            new_borne.machine_ptr_id = borne.machine.pk
+            new_borne.__dict__.update(borne.machine.__dict__)
+            new_borne.location = borne.location
+            new_borne.save()
+
+    def untransfer_ap(apps, schema_editor):
+        return
+
+    operations = [
+        migrations.RunPython(transfer_ap, untransfer_ap),
+        migrations.DeleteModel(
+            name='AccessPoint',
+        ),
+        migrations.RenameModel(
+        old_name='NewAccessPoint',
+        new_name='AccessPoint',
+        ),
+    ]
diff --git a/topologie/models.py b/topologie/models.py
index d94c5704..76b24652 100644
--- a/topologie/models.py
+++ b/topologie/models.py
@@ -47,7 +47,7 @@ from django.db import IntegrityError
 from django.db import transaction
 from reversion import revisions as reversion
 
-from machines.models import Interface
+from machines.models import Machine, Interface
 
 class Stack(models.Model):
     """Un objet stack. Regrouppe des switchs en foreign key
@@ -109,7 +109,7 @@ class Stack(models.Model):
                 inférieure à l'id minimale"})
 
 
-class AccessPoint(Interface):
+class AccessPoint(Machine):
     """Define a wireless AP. Inherit from machines.interfaces
     
     Definition pour une borne wifi , hérite de machines.interfaces
diff --git a/topologie/templates/topologie/aff_ap.html b/topologie/templates/topologie/aff_ap.html
index b9130a0d..192e5026 100644
--- a/topologie/templates/topologie/aff_ap.html
+++ b/topologie/templates/topologie/aff_ap.html
@@ -43,10 +43,10 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 		</thead>
 		{% for ap in ap_list %}
 		<tr>
-			<td>{{ap}}</td>
-			<td>{{ap.mac_address}}</td>
-			<td>{{ap.ipv4}}</td>
-			<td>{{ap.details}}</td>
+			<td>{{ap.interface_set.first}}</td>
+			<td>{{ap.interface_set.first.mac_address}}</td>
+			<td>{{ap.interface_set.first.ipv4}}</td>
+			<td>{{ap.interface_set.first.details}}</td>
 			<td>{{ap.location}}</td>
 			<td class="text-right">
 				<a class="btn btn-info btn-sm" role="button" title="Historique" href="{% url 'topologie:history' 'ap' ap.pk %}">
@@ -58,7 +58,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 				</a>
 				{% acl_end %}
 				{% can_delete ap %}
-				<a class="btn btn-danger btn-sm" role="button" title="Supprimer" href="{% url 'machines:del-interface' ap.id %}">
+				<a class="btn btn-danger btn-sm" role="button" title="Supprimer" href="{% url 'machines:del-machine' ap.id %}">
 					<i class="fa fa-trash"></i>
 				</a>
 				{% acl_end %}
diff --git a/topologie/views.py b/topologie/views.py
index 6102bb66..3fa846df 100644
--- a/topologie/views.py
+++ b/topologie/views.py
@@ -535,45 +535,45 @@ def new_ap(request):
         request.POST or None,
         user=request.user
     )
-    machine = NewMachineForm(
+    interface = AddInterfaceForm(
         request.POST or None,
         user=request.user
     )
     domain = DomainForm(
         request.POST or None,
         )
-    if ap.is_valid() and machine.is_valid():
+    if ap.is_valid() and interface.is_valid():
         user = AssoOption.get_cached_value('utilisateur_asso')
         if not user:
             messages.error(request, "L'user association n'existe pas encore,\
             veuillez le créer ou le linker dans preferences")
             return redirect(reverse('topologie:index'))
-        new_machine = machine.save(commit=False)
-        new_machine.user = user
         new_ap = ap.save(commit=False)
-        domain.instance.interface_parent = new_ap
+        new_ap.user = user
+        new_interface = interface.save(commit=False)
+        domain.instance.interface_parent = new_interface
         if domain.is_valid():
             new_domain_instance = domain.save(commit=False)
-            with transaction.atomic(), reversion.create_revision():
-                new_machine.save()
-                reversion.set_user(request.user)
-                reversion.set_comment("Création")
-            new_ap.machine = new_machine
             with transaction.atomic(), reversion.create_revision():
                 new_ap.save()
                 reversion.set_user(request.user)
                 reversion.set_comment("Création")
-            new_domain_instance.interface_parent = new_ap
+            new_interface.machine = new_ap
+            with transaction.atomic(), reversion.create_revision():
+                new_interface.save()
+                reversion.set_user(request.user)
+                reversion.set_comment("Création")
+            new_domain_instance.interface_parent = new_interface
             with transaction.atomic(), reversion.create_revision():
                 new_domain_instance.save()
                 reversion.set_user(request.user)
                 reversion.set_comment("Création")
             messages.success(request, "La borne a été créé")
             return redirect(reverse('topologie:index-ap'))
-    i_mbf_param = generate_ipv4_mbf_param(ap, False)
+    i_mbf_param = generate_ipv4_mbf_param(interface, False)
     return form({
-        'topoform': ap,
-        'machineform': machine,
+        'topoform': interface,
+        'machineform': ap,
         'domainform': domain,
         'i_mbf_param': i_mbf_param,
         'device' : 'wifi ap',
@@ -585,41 +585,41 @@ def new_ap(request):
 def edit_ap(request, ap, ap_id):
     """ Edition d'un switch. Permet de chambre nombre de ports,
     place dans le stack, interface et machine associée"""
+    interface_form = EditInterfaceForm(
+        request.POST or None,
+        user=request.user,
+        instance=ap.interface_set.first()
+    )
     ap_form = EditAccessPointForm(
         request.POST or None,
         user=request.user,
         instance=ap
     )
-    machine_form = NewMachineForm(
-        request.POST or None,
-        user=request.user,
-        instance=ap.machine
-    )
     domain_form = DomainForm(
         request.POST or None,
-        instance=ap.domain
+        instance=ap.interface_set.first().domain
         )
-    if ap_form.is_valid() and machine_form.is_valid():
+    if ap_form.is_valid() and interface_form.is_valid():
         user = AssoOption.get_cached_value('utilisateur_asso')
         if not user:
             messages.error(request, "L'user association n'existe pas encore,\
             veuillez le créer ou le linker dans preferences")
             return redirect(reverse('topologie:index-ap'))
-        new_machine = machine_form.save(commit=False)
         new_ap = ap_form.save(commit=False)
+        new_interface = interface_form.save(commit=False)
         new_domain = domain_form.save(commit=False)
-        with transaction.atomic(), reversion.create_revision():
-            new_machine.save()
-            reversion.set_user(request.user)
-            reversion.set_comment(
-                "Champs modifié(s) : %s" % ', '.join(
-                    field for field in machine_form.changed_data)
-            )
         with transaction.atomic(), reversion.create_revision():
             new_ap.save()
             reversion.set_user(request.user)
+            reversion.set_comment(
+                "Champs modifié(s) : %s" % ', '.join(
+                    field for field in ap_form.changed_data)
+            )
+        with transaction.atomic(), reversion.create_revision():
+            new_interface.save()
+            reversion.set_user(request.user)
             reversion.set_comment("Champs modifié(s) : %s" % ', '.join(
-                field for field in ap_form.changed_data)
+                field for field in interface_form.changed_data)
             )
             reversion.set_comment("Création")
         with transaction.atomic(), reversion.create_revision():
@@ -630,10 +630,10 @@ def edit_ap(request, ap, ap_id):
             )
         messages.success(request, "La borne a été modifiée")
         return redirect(reverse('topologie:index-ap'))
-    i_mbf_param = generate_ipv4_mbf_param(ap_form, False )
+    i_mbf_param = generate_ipv4_mbf_param(interface_form, False )
     return form({
-        'topoform': ap_form,
-        'machineform': machine_form,
+        'topoform': interface_form,
+        'machineform': ap_form,
         'domainform': domain_form,
         'i_mbf_param': i_mbf_param,
         'device' : 'wifi ap',

From 004f6099f5172a031b97189a6b8a51160668ea27 Mon Sep 17 00:00:00 2001
From: Gabriel Detraz <detraz@crans.org>
Date: Mon, 26 Mar 2018 05:12:01 +0200
Subject: [PATCH 22/26] =?UTF-8?q?Switchs=20h=C3=A9ritent=20de=20machines?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 re2o/utils.py                                 |  4 +-
 topologie/forms.py                            |  8 +--
 topologie/migrations/0049_switchs_machine.py  | 30 +++++++++
 topologie/migrations/0050_port_new_switch.py  | 21 +++++++
 topologie/migrations/0051_transferports.py    | 33 ++++++++++
 topologie/migrations/0052_switchs_machine.py  | 42 +++++++++++++
 topologie/migrations/0053_finalsw.py          | 22 +++++++
 topologie/models.py                           |  2 +-
 topologie/templates/topologie/aff_switch.html |  6 +-
 topologie/views.py                            | 63 +++++++++----------
 10 files changed, 189 insertions(+), 42 deletions(-)
 create mode 100644 topologie/migrations/0049_switchs_machine.py
 create mode 100644 topologie/migrations/0050_port_new_switch.py
 create mode 100644 topologie/migrations/0051_transferports.py
 create mode 100644 topologie/migrations/0052_switchs_machine.py
 create mode 100644 topologie/migrations/0053_finalsw.py

diff --git a/re2o/utils.py b/re2o/utils.py
index fcb4f8a8..32be2432 100644
--- a/re2o/utils.py
+++ b/re2o/utils.py
@@ -213,8 +213,8 @@ class SortTable:
         'default': ['-date']
     }
     TOPOLOGIE_INDEX = {
-        'switch_dns': ['switch_interface__domain__name'],
-        'switch_ip': ['switch_interface__ipv4__ipv4'],
+        'switch_dns': ['interface__domain__name'],
+        'switch_ip': ['interface__ipv4__ipv4'],
         'switch_loc': ['location'],
         'switch_ports': ['number'],
         'switch_stack': ['stack__name'],
diff --git a/topologie/forms.py b/topologie/forms.py
index 5032d15e..0337dc60 100644
--- a/topologie/forms.py
+++ b/topologie/forms.py
@@ -130,18 +130,18 @@ class EditAccessPointForm(EditMachineForm):
         fields = '__all__'
 
 
-class EditSwitchForm(EditInterfaceForm):
+class EditSwitchForm(EditMachineForm):
     """Permet d'éditer un switch : nom et nombre de ports"""
     class Meta:
         model = Switch
-        fields = ['machine', 'type', 'ipv4', 'mac_address', 'details', 'location', 'number', 'stack', 'stack_member_id']
+        fields = '__all__'
 
 
-class NewSwitchForm(EditInterfaceForm):
+class NewSwitchForm(NewMachineForm):
     """Permet de créer un switch : emplacement, paramètres machine,
     membre d'un stack (option), nombre de ports (number)"""
     class Meta(EditSwitchForm.Meta):
-        fields = ['type', 'ipv4', 'mac_address', 'details', 'location', 'number', 'stack', 'stack_member_id']
+        fields = ['name', 'location', 'number', 'stack', 'stack_member_id']
 
 
 class EditRoomForm(ModelForm):
diff --git a/topologie/migrations/0049_switchs_machine.py b/topologie/migrations/0049_switchs_machine.py
new file mode 100644
index 00000000..040ab599
--- /dev/null
+++ b/topologie/migrations/0049_switchs_machine.py
@@ -0,0 +1,30 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.7 on 2018-03-23 01:18
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('topologie', '0048_ap_machine'),
+    ]
+
+
+
+    operations = [
+        migrations.CreateModel(
+            name='NewSw',
+            fields=[
+                ('machine_ptr', models.OneToOneField(auto_created=True, on_delete=django.db.models.deletion.CASCADE, parent_link=True, primary_key=True, serialize=False, to='machines.Machine')),
+                ('location', models.CharField(max_length=255)),
+                ('number', models.PositiveIntegerField()),
+                ('stack_member_id', models.PositiveIntegerField(blank=True, null=True)),
+                ('model', models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.SET_NULL, to='topologie.ModelSwitch')),
+                ('stack', models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.SET_NULL, to='topologie.Stack')),
+            ],
+            bases=('machines.machine',),
+        ),
+    ]
diff --git a/topologie/migrations/0050_port_new_switch.py b/topologie/migrations/0050_port_new_switch.py
new file mode 100644
index 00000000..b03a8ee5
--- /dev/null
+++ b/topologie/migrations/0050_port_new_switch.py
@@ -0,0 +1,21 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.7 on 2018-03-25 00:52
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('topologie', '0049_switchs_machine'),
+    ]
+
+    operations = [
+        migrations.AddField(
+            model_name='port',
+            name='new_sw',
+            field=models.ForeignKey(blank=True, null=True, on_delete=django.db.models.deletion.CASCADE, related_name='ports', to='topologie.NewSw'),
+        ),
+    ]
diff --git a/topologie/migrations/0051_transferports.py b/topologie/migrations/0051_transferports.py
new file mode 100644
index 00000000..2a67e6be
--- /dev/null
+++ b/topologie/migrations/0051_transferports.py
@@ -0,0 +1,33 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.7 on 2017-12-31 19:53
+from __future__ import unicode_literals
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('topologie', '0050_port_new_switch'),
+    ]
+
+    def transfer_port(apps, schema_editor):
+        db_alias = schema_editor.connection.alias
+        port = apps.get_model("topologie", "Port")
+        switch = apps.get_model("topologie", "NewSw")
+        port_list = port.objects.using(db_alias).all()
+        for p in port_list:
+            p.new_sw = switch.objects.filter(machine_ptr=p.switch.machine).first()
+            p.save()
+
+    def untransfer_port(apps, schema_editor):
+        return
+
+    operations = [
+    migrations.RunPython(transfer_port, untransfer_port),
+    migrations.RemoveField(
+    model_name='port',
+    name='switch',
+    ),
+    migrations.RenameField('Port', 'new_sw', 'switch')
+    ]
diff --git a/topologie/migrations/0052_switchs_machine.py b/topologie/migrations/0052_switchs_machine.py
new file mode 100644
index 00000000..b32b3c18
--- /dev/null
+++ b/topologie/migrations/0052_switchs_machine.py
@@ -0,0 +1,42 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.7 on 2018-03-23 01:18
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('topologie', '0051_transferports'),
+    ]
+
+    def transfer_sw(apps, schema_editor):
+        db_alias = schema_editor.connection.alias
+        newswitch = apps.get_model("topologie", "NewSw")
+        switch = apps.get_model("topologie", "Switch")
+        machine =  apps.get_model("machines", "Machine")
+        sw_list = switch.objects.using(db_alias).all()
+        for sw in sw_list:
+            new_sw = newswitch()
+            new_sw.location = sw.location
+            new_sw.number = sw.number
+            new_sw.details = sw.details
+            new_sw.stack = sw.stack
+            new_sw.stack_member_id = sw.stack_member_id
+            new_sw.model = sw.model
+            new_sw.machine_ptr_id = sw.interface_ptr.machine.pk
+            new_sw.__dict__.update(sw.interface_ptr.machine.__dict__) 
+            new_sw.save()
+
+    def untransfer_sw(apps, schema_editor):
+        return
+
+
+    operations = [
+        migrations.RunPython(transfer_sw, untransfer_sw),
+        migrations.DeleteModel(
+            name='Switch',
+        ),
+    ]
diff --git a/topologie/migrations/0053_finalsw.py b/topologie/migrations/0053_finalsw.py
new file mode 100644
index 00000000..561e0dc3
--- /dev/null
+++ b/topologie/migrations/0053_finalsw.py
@@ -0,0 +1,22 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.7 on 2018-03-23 01:18
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('topologie', '0052_switchs_machine'),
+    ]
+
+
+
+    operations = [
+        migrations.RenameModel(
+        old_name='NewSw',
+        new_name='Switch',
+        ),
+    ]
diff --git a/topologie/models.py b/topologie/models.py
index 76b24652..fd4b1d3d 100644
--- a/topologie/models.py
+++ b/topologie/models.py
@@ -156,7 +156,7 @@ class AccessPoint(Machine):
         return True, None
 
 
-class Switch(Interface):
+class Switch(Machine):
     """ Definition d'un switch. Contient un nombre de ports (number),
     un emplacement (location), un stack parent (optionnel, stack)
     et un id de membre dans le stack (stack_member_id)
diff --git a/topologie/templates/topologie/aff_switch.html b/topologie/templates/topologie/aff_switch.html
index c8c9e6e0..948cd209 100644
--- a/topologie/templates/topologie/aff_switch.html
+++ b/topologie/templates/topologie/aff_switch.html
@@ -46,10 +46,10 @@ with this program; if not, write to the Free Software Foundation, Inc.,
    <tr>
        <td>
            <a title="Configuer" href="{% url 'topologie:index-port' switch.pk %}">
-               {{switch}}
+           {{switch.interface_set.first}}
            </a>
        </td>
-       <td>{{switch.ipv4}}</td>
+       <td>{{switch.interface_set.first.ipv4}}</td>
        <td>{{switch.location}}</td>
        <td>{{switch.number}}</td>
        <td>{{switch.stack.name}}</td>
@@ -62,7 +62,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
            {% include 'buttons/edit.html' with href='topologie:edit-switch' id=switch.pk %}
 	   {% acl_end %}
 	   {% can_delete switch %}
-           {% include 'buttons/suppr.html' with href='machines:del-interface' id=switch.id %} 
+           {% include 'buttons/suppr.html' with href='machines:del-machine' id=switch.id %} 
 	   {% acl_end %}
 	   {% can_create Port %}
 	   {% include 'buttons/add.html' with href='topologie:create-ports' id=switch.pk desc='Création de ports'%}
diff --git a/topologie/views.py b/topologie/views.py
index 3fa846df..68febece 100644
--- a/topologie/views.py
+++ b/topologie/views.py
@@ -92,9 +92,9 @@ from preferences.models import AssoOption, GeneralOption
 def index(request):
     """ Vue d'affichage de tous les swicthes"""
     switch_list = Switch.objects\
-        .select_related('domain__extension')\
-        .select_related('ipv4')\
-        .select_related('domain')\
+        .prefetch_related('interface_set__domain__extension')\
+        .prefetch_related('interface_set__ipv4__ip_type')\
+        .prefetch_related('interface_set__type__ip_type__extension')\
         .select_related('stack')
     switch_list = SortTable.sort(
         switch_list,
@@ -127,9 +127,8 @@ def index_port(request, switch, switch_id):
         .select_related('room')\
         .select_related('machine_interface__domain__extension')\
         .select_related('machine_interface__machine__user')\
-        .select_related(
-            'related__switch__domain__extension'
-        )\
+        .select_related('related__switch')\
+        .prefetch_related('related__switch__interface_set__domain__extension')\
         .select_related('switch')
     port_list = SortTable.sort(
         port_list,
@@ -385,45 +384,45 @@ def new_switch(request):
         request.POST or None,
         user=request.user
     )
-    machine = NewMachineForm(
+    interface = AddInterfaceForm(
         request.POST or None,
         user=request.user
     )
     domain = DomainForm(
         request.POST or None,
         )
-    if switch.is_valid() and machine.is_valid():
+    if switch.is_valid() and interface.is_valid():
         user = AssoOption.get_cached_value('utilisateur_asso')
         if not user:
             messages.error(request, "L'user association n'existe pas encore,\
             veuillez le créer ou le linker dans preferences")
             return redirect(reverse('topologie:index'))
-        new_machine = machine.save(commit=False)
-        new_machine.user = user
-        new_switch_instance = switch.save(commit=False)
-        domain.instance.interface_parent = new_switch_instance
+        new_switch = switch.save(commit=False)
+        new_switch.user = user
+        new_interface_instance = interface.save(commit=False)
+        domain.instance.interface_parent = new_interface_instance
         if domain.is_valid():
             new_domain_instance = domain.save(commit=False)
             with transaction.atomic(), reversion.create_revision():
-                new_machine.save()
+                new_switch.save()
                 reversion.set_user(request.user)
                 reversion.set_comment("Création")
-            new_switch_instance.machine = new_machine
+            new_interface_instance.machine = new_switch
             with transaction.atomic(), reversion.create_revision():
-                new_switch_instance.save()
+                new_interface_instance.save()
                 reversion.set_user(request.user)
                 reversion.set_comment("Création")
-            new_domain_instance.interface_parent = new_switch_instance
+            new_domain_instance.interface_parent = new_interface_instance
             with transaction.atomic(), reversion.create_revision():
                 new_domain_instance.save()
                 reversion.set_user(request.user)
                 reversion.set_comment("Création")
             messages.success(request, "Le switch a été créé")
             return redirect(reverse('topologie:index'))
-    i_mbf_param = generate_ipv4_mbf_param(switch, False)
+    i_mbf_param = generate_ipv4_mbf_param(interface, False)
     return form({
-        'topoform': switch,
-        'machineform': machine,
+        'topoform': interface,
+        'machineform': switch,
         'domainform': domain,
         'i_mbf_param': i_mbf_param,
         'device' : 'switch',
@@ -479,32 +478,32 @@ def edit_switch(request, switch, switch_id):
         instance=switch,
         user=request.user
         )
-    machine_form = EditMachineForm(
+    interface_form = EditInterfaceForm(
         request.POST or None,
-        instance=switch.machine,
+        instance=switch.interface_set.first(),
         user=request.user
         )
     domain_form = DomainForm(
         request.POST or None,
-        instance=switch.domain
+        instance=switch.interface_set.first().domain
         )
-    if switch_form.is_valid() and machine_form.is_valid():
-        new_machine = machine_form.save(commit=False)
-        new_switch_instance = switch_form.save(commit=False)
+    if switch_form.is_valid() and interface_form.is_valid():
+        new_switch = switch_form.save(commit=False)
+        new_interface_instance = interface_form.save(commit=False)
         new_domain = domain_form.save(commit=False)
         with transaction.atomic(), reversion.create_revision():
-            new_machine.save()
+            new_switch.save()
             reversion.set_user(request.user)
             reversion.set_comment(
                 "Champs modifié(s) : %s" % ', '.join(
-                    field for field in machine_form.changed_data
+                    field for field in switch_form.changed_data
                     )
                 )
         with transaction.atomic(), reversion.create_revision():
-            new_switch_instance.save()
+            new_interface_instance.save()
             reversion.set_user(request.user)
             reversion.set_comment("Champs modifié(s) : %s" % ', '.join(
-                field for field in switch_form.changed_data)
+                field for field in interface_form.changed_data)
                                  )
         with transaction.atomic(), reversion.create_revision():
             new_domain.save()
@@ -514,11 +513,11 @@ def edit_switch(request, switch, switch_id):
                                  )
         messages.success(request, "Le switch a bien été modifié")
         return redirect(reverse('topologie:index'))
-    i_mbf_param = generate_ipv4_mbf_param(switch_form, False )
+    i_mbf_param = generate_ipv4_mbf_param(interface_form, False )
     return form({
         'id_switch': switch_id,
-        'topoform': switch_form,
-        'machineform': machine_form,
+        'topoform': interface_form,
+        'machineform': switch_form,
         'domainform': domain_form,
         'i_mbf_param': i_mbf_param,
         'device' : 'switch',

From 1a59c85577011e2137b07d9a1871f123c92d50f6 Mon Sep 17 00:00:00 2001
From: Gabriel Detraz <detraz@crans.org>
Date: Mon, 26 Mar 2018 17:38:39 +0200
Subject: [PATCH 23/26] Fix ordre des migrations

---
 .../{0052_switchs_machine.py => 0051_switchs_machine.py}    | 5 +----
 .../{0051_transferports.py => 0052_transferports.py}        | 6 +++++-
 topologie/migrations/0053_finalsw.py                        | 5 ++++-
 3 files changed, 10 insertions(+), 6 deletions(-)
 rename topologie/migrations/{0052_switchs_machine.py => 0051_switchs_machine.py} (91%)
 rename topologie/migrations/{0051_transferports.py => 0052_transferports.py} (85%)

diff --git a/topologie/migrations/0052_switchs_machine.py b/topologie/migrations/0051_switchs_machine.py
similarity index 91%
rename from topologie/migrations/0052_switchs_machine.py
rename to topologie/migrations/0051_switchs_machine.py
index b32b3c18..d7f1da86 100644
--- a/topologie/migrations/0052_switchs_machine.py
+++ b/topologie/migrations/0051_switchs_machine.py
@@ -9,7 +9,7 @@ import django.db.models.deletion
 class Migration(migrations.Migration):
 
     dependencies = [
-        ('topologie', '0051_transferports'),
+        ('topologie', '0050_port_new_switch'),
     ]
 
     def transfer_sw(apps, schema_editor):
@@ -36,7 +36,4 @@ class Migration(migrations.Migration):
 
     operations = [
         migrations.RunPython(transfer_sw, untransfer_sw),
-        migrations.DeleteModel(
-            name='Switch',
-        ),
     ]
diff --git a/topologie/migrations/0051_transferports.py b/topologie/migrations/0052_transferports.py
similarity index 85%
rename from topologie/migrations/0051_transferports.py
rename to topologie/migrations/0052_transferports.py
index 2a67e6be..88badbe6 100644
--- a/topologie/migrations/0051_transferports.py
+++ b/topologie/migrations/0052_transferports.py
@@ -8,7 +8,7 @@ from django.db import migrations
 class Migration(migrations.Migration):
 
     dependencies = [
-        ('topologie', '0050_port_new_switch'),
+        ('topologie', '0051_switchs_machine'),
     ]
 
     def transfer_port(apps, schema_editor):
@@ -24,6 +24,10 @@ class Migration(migrations.Migration):
         return
 
     operations = [
+    migrations.AlterUniqueTogether(
+        name='port',
+        unique_together=set([]),
+    ),
     migrations.RunPython(transfer_port, untransfer_port),
     migrations.RemoveField(
     model_name='port',
diff --git a/topologie/migrations/0053_finalsw.py b/topologie/migrations/0053_finalsw.py
index 561e0dc3..2ed7e2ac 100644
--- a/topologie/migrations/0053_finalsw.py
+++ b/topologie/migrations/0053_finalsw.py
@@ -9,12 +9,15 @@ import django.db.models.deletion
 class Migration(migrations.Migration):
 
     dependencies = [
-        ('topologie', '0052_switchs_machine'),
+        ('topologie', '0052_transferports'),
     ]
 
 
 
     operations = [
+        migrations.DeleteModel(
+        name='Switch',
+        ),
         migrations.RenameModel(
         old_name='NewSw',
         new_name='Switch',

From 02240a8fce787a8acc986092c4710c5557e6f2d3 Mon Sep 17 00:00:00 2001
From: Gabriel Detraz <detraz@crans.org>
Date: Mon, 26 Mar 2018 18:07:36 +0200
Subject: [PATCH 24/26] Final migrations pour switchs

---
 .../migrations/0054_auto_20180326_1742.py     | 38 +++++++++++++++++++
 topologie/templates/topologie/aff_switch.html |  2 +-
 2 files changed, 39 insertions(+), 1 deletion(-)
 create mode 100644 topologie/migrations/0054_auto_20180326_1742.py

diff --git a/topologie/migrations/0054_auto_20180326_1742.py b/topologie/migrations/0054_auto_20180326_1742.py
new file mode 100644
index 00000000..cfaff01b
--- /dev/null
+++ b/topologie/migrations/0054_auto_20180326_1742.py
@@ -0,0 +1,38 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.7 on 2018-03-26 15:42
+from __future__ import unicode_literals
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('topologie', '0053_finalsw'),
+    ]
+
+    operations = [
+        migrations.AlterModelOptions(
+            name='accesspoint',
+            options={'permissions': (('view_ap', 'Peut voir une borne'),)},
+        ),
+        migrations.AlterModelOptions(
+            name='switch',
+            options={'permissions': (('view_switch', 'Peut voir un objet switch'),)},
+        ),
+        migrations.AlterField(
+            model_name='port',
+            name='switch',
+            field=models.ForeignKey(on_delete=django.db.models.deletion.CASCADE, related_name='ports', to='topologie.Switch'),
+            preserve_default=False,
+        ),
+        migrations.AlterUniqueTogether(
+            name='port',
+            unique_together=set([('switch', 'port')]),
+        ),
+        migrations.AlterUniqueTogether(
+            name='switch',
+            unique_together=set([('stack', 'stack_member_id')]),
+        ),
+    ]
diff --git a/topologie/templates/topologie/aff_switch.html b/topologie/templates/topologie/aff_switch.html
index 948cd209..0805b591 100644
--- a/topologie/templates/topologie/aff_switch.html
+++ b/topologie/templates/topologie/aff_switch.html
@@ -55,7 +55,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
        <td>{{switch.stack.name}}</td>
        <td>{{switch.stack_member_id}}</td>
        <td>{{switch.model}}</td>
-       <td>{{switch.details}}</td>
+       <td>{{switch.interface_set.first.details}}</td>
        <td class="text-right">
        	   {% include 'buttons/history.html' with href='topologie:history' name='switch' id=switch.pk%}
        	   {% can_edit switch %}

From 3ce73a7a467a8b2ba4fdc59de7f24a1e701eb754 Mon Sep 17 00:00:00 2001
From: Gabriel Detraz <detraz@crans.org>
Date: Mon, 26 Mar 2018 22:11:03 +0200
Subject: [PATCH 25/26] Fix divers sur la creation de port

---
 topologie/forms.py                            | 10 ++++++----
 topologie/models.py                           |  7 +++++--
 topologie/templates/topologie/aff_switch.html |  2 +-
 3 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/topologie/forms.py b/topologie/forms.py
index 0337dc60..653cd0c5 100644
--- a/topologie/forms.py
+++ b/topologie/forms.py
@@ -80,9 +80,10 @@ class EditPortForm(ModelForm):
         prefix = kwargs.pop('prefix', self.Meta.model.__name__)
         super(EditPortForm, self).__init__(*args, prefix=prefix, **kwargs)
         self.fields['machine_interface'].queryset = Interface.objects.all()\
-            .select_related('domain__extension')
+           .select_related('domain__extension')
         self.fields['related'].queryset = Port.objects.all()\
-            .select_related('switch__domain__extension')\
+            .select_related('switch')\
+            .prefetch_related('switch__interface_set__domain__extension')\
             .order_by('switch', 'port')
 
 
@@ -97,9 +98,10 @@ class AddPortForm(ModelForm):
         prefix = kwargs.pop('prefix', self.Meta.model.__name__)
         super(AddPortForm, self).__init__(*args, prefix=prefix, **kwargs)
         self.fields['machine_interface'].queryset = Interface.objects.all()\
-            .select_related('domain__extension')
+           .select_related('domain__extension')
         self.fields['related'].queryset = Port.objects.all()\
-            .select_related('switch__domain__extension')\
+            .select_related('switch')\
+            .prefetch_related('switch__interface_set__domain__extension')\
             .order_by('switch', 'port')
 
 
diff --git a/topologie/models.py b/topologie/models.py
index fd4b1d3d..3cf0d5b2 100644
--- a/topologie/models.py
+++ b/topologie/models.py
@@ -263,6 +263,9 @@ class Switch(Machine):
             except IntegrityError:
                 ValidationError("Création d'un port existant.")
 
+    def __str__(self):
+        return str(self.interface_set.first())
+
 
 class ModelSwitch(models.Model):
     """Un modèle (au sens constructeur) de switch"""
@@ -416,11 +419,11 @@ class Port(models.Model):
 
     def get_instance(port_id, *args, **kwargs):
         return Port.objects\
-            .select_related('switch__domain__extension')\
             .select_related('machine_interface__domain__extension')\
-            .select_related('machine_interface__switch')\
+            .select_related('machine_interface__machine__switch')\
             .select_related('room')\
             .select_related('related')\
+            .prefetch_related('switch__interface_set__domain__extension')\
             .get(pk=port_id)
 
     def can_create(user_request, *args, **kwargs):
diff --git a/topologie/templates/topologie/aff_switch.html b/topologie/templates/topologie/aff_switch.html
index 0805b591..bcbe5204 100644
--- a/topologie/templates/topologie/aff_switch.html
+++ b/topologie/templates/topologie/aff_switch.html
@@ -46,7 +46,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
    <tr>
        <td>
            <a title="Configuer" href="{% url 'topologie:index-port' switch.pk %}">
-           {{switch.interface_set.first}}
+           {{switch}}
            </a>
        </td>
        <td>{{switch.interface_set.first.ipv4}}</td>

From fc7f98539281750f5d7df43de5495c4a947cc592 Mon Sep 17 00:00:00 2001
From: Gabriel Detraz <detraz@crans.org>
Date: Tue, 27 Mar 2018 01:26:17 +0200
Subject: [PATCH 26/26] =?UTF-8?q?Adapte=20auth.py=20au=20nouveau=20syst?=
 =?UTF-8?q?=C3=A8me=20de=20switchs=20+=20optimisations=20forms?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 freeradius_utils/auth.py | 18 ++++++++++--------
 topologie/forms.py       | 15 +++++++++------
 topologie/views.py       | 21 +++++++++++++++------
 3 files changed, 34 insertions(+), 20 deletions(-)

diff --git a/freeradius_utils/auth.py b/freeradius_utils/auth.py
index 4ab45b25..c20764e9 100644
--- a/freeradius_utils/auth.py
+++ b/freeradius_utils/auth.py
@@ -192,19 +192,21 @@ def post_auth(data):
 
     mac = data.get('Calling-Station-Id', None)
 
+    # Switch et bornes héritent de machine et peuvent avoir plusieurs interfaces filles
+    nas_machine = nas_instance.machine
     # Si il s'agit d'un switch
-    if hasattr(nas_instance, 'switch'):
+    if hasattr(nas_machine, 'switch'):
         port = data.get('NAS-Port-Id', data.get('NAS-Port', None))
         #Pour les infrastructures possédant des switchs Juniper :
         #On vérifie si le switch fait partie d'un stack Juniper
-        instance_stack = nas_instance.switch.stack
+        instance_stack = nas_machine.switch.stack
         if instance_stack:
             # Si c'est le cas, on resélectionne le bon switch dans la stack
             id_stack_member = port.split("-")[1].split('/')[0]
-            nas_instance = Switch.objects.filter(stack=instance_stack).filter(stack_member_id=id_stack_member).select_related('domain__extension').first()
+            nas_machine = Switch.objects.filter(stack=instance_stack).filter(stack_member_id=id_stack_member).prefetch_related('interface_set__domain__extension').first()
         # On récupère le numéro du port sur l'output de freeradius. La ligne suivante fonctionne pour cisco, HP et Juniper
         port = port.split(".")[0].split('/')[-1][-2:]
-        out = decide_vlan_and_register_switch(nas_instance, nas_type, port, mac)
+        out = decide_vlan_and_register_switch(nas_machine, nas_type, port, mac)
         sw_name, room, reason, vlan_id = out
 
         log_message = '(fil) %s -> %s [%s%s]' % \
@@ -271,7 +273,7 @@ def check_user_machine_and_register(nas_type, username, mac_address):
         return (False, u"Machine inconnue", '')
 
 
-def decide_vlan_and_register_switch(nas, nas_type, port_number, mac_address):
+def decide_vlan_and_register_switch(nas_machine, nas_type, port_number, mac_address):
     """Fonction de placement vlan pour un switch en radius filaire auth par mac.
     Plusieurs modes :
     - nas inconnu, port inconnu : on place sur le vlan par defaut VLAN_OK
@@ -296,12 +298,12 @@ def decide_vlan_and_register_switch(nas, nas_type, port_number, mac_address):
     # Get port from switch and port number
     extra_log = ""
     # Si le NAS est inconnu, on place sur le vlan defaut
-    if not nas:
+    if not nas_machine:
         return ('?', u'Chambre inconnue', u'Nas inconnu', VLAN_OK)
 
-    sw_name = str(nas)
+    sw_name = str(nas_machine)
 
-    port = Port.objects.filter(switch=Switch.objects.filter(interface_ptr=nas), port=port_number).first()
+    port = Port.objects.filter(switch=Switch.objects.filter(machine_ptr=nas_machine), port=port_number).first()
     #Si le port est inconnu, on place sur le vlan defaut
     if not port:
         return (sw_name, "Chambre inconnue", u'Port inconnu', VLAN_OK)
diff --git a/topologie/forms.py b/topologie/forms.py
index 653cd0c5..7b8f0955 100644
--- a/topologie/forms.py
+++ b/topologie/forms.py
@@ -40,6 +40,7 @@ from machines.forms import (
 )
 from django import forms
 from django.forms import ModelForm, Form
+from django.db.models import Prefetch
 from .models import ( 
     Port,
     Switch,
@@ -82,9 +83,10 @@ class EditPortForm(ModelForm):
         self.fields['machine_interface'].queryset = Interface.objects.all()\
            .select_related('domain__extension')
         self.fields['related'].queryset = Port.objects.all()\
-            .select_related('switch')\
-            .prefetch_related('switch__interface_set__domain__extension')\
-            .order_by('switch', 'port')
+            .prefetch_related(Prefetch(
+            'switch__interface_set',
+            queryset=Interface.objects.select_related('ipv4__ip_type__extension').select_related('domain__extension')
+            ))
 
 
 class AddPortForm(ModelForm):
@@ -100,9 +102,10 @@ class AddPortForm(ModelForm):
         self.fields['machine_interface'].queryset = Interface.objects.all()\
            .select_related('domain__extension')
         self.fields['related'].queryset = Port.objects.all()\
-            .select_related('switch')\
-            .prefetch_related('switch__interface_set__domain__extension')\
-            .order_by('switch', 'port')
+            .prefetch_related(Prefetch(
+            'switch__interface_set',
+            queryset=Interface.objects.select_related('ipv4__ip_type__extension').select_related('domain__extension')
+            ))
 
 
 class StackForm(ModelForm):
diff --git a/topologie/views.py b/topologie/views.py
index 68febece..bc53c77b 100644
--- a/topologie/views.py
+++ b/topologie/views.py
@@ -41,7 +41,7 @@ from django.contrib import messages
 from django.contrib.auth.decorators import login_required, permission_required
 from django.db import IntegrityError
 from django.db import transaction
-from django.db.models import ProtectedError
+from django.db.models import ProtectedError, Prefetch
 from django.core.exceptions import ValidationError
 from django.core.paginator import Paginator, EmptyPage, PageNotAnInteger
 from reversion import revisions as reversion
@@ -84,6 +84,7 @@ from machines.forms import (
     AddInterfaceForm
 )
 from machines.views import generate_ipv4_mbf_param
+from machines.models import Interface
 from preferences.models import AssoOption, GeneralOption
 
 
@@ -92,9 +93,10 @@ from preferences.models import AssoOption, GeneralOption
 def index(request):
     """ Vue d'affichage de tous les swicthes"""
     switch_list = Switch.objects\
-        .prefetch_related('interface_set__domain__extension')\
-        .prefetch_related('interface_set__ipv4__ip_type')\
-        .prefetch_related('interface_set__type__ip_type__extension')\
+        .prefetch_related(Prefetch(
+            'interface_set',
+        queryset=Interface.objects.select_related('ipv4__ip_type__extension').select_related('domain__extension')
+        ))\
         .select_related('stack')
     switch_list = SortTable.sort(
         switch_list,
@@ -128,7 +130,10 @@ def index_port(request, switch, switch_id):
         .select_related('machine_interface__domain__extension')\
         .select_related('machine_interface__machine__user')\
         .select_related('related__switch')\
-        .prefetch_related('related__switch__interface_set__domain__extension')\
+        .prefetch_related(Prefetch(
+            'related__switch__interface_set',
+            queryset=Interface.objects.select_related('domain__extension')
+        ))\
         .select_related('switch')
     port_list = SortTable.sort(
         port_list,
@@ -174,7 +179,11 @@ def index_room(request):
 @can_view_all(AccessPoint)
 def index_ap(request):
     """ Affichage de l'ensemble des bornes"""
-    ap_list = AccessPoint.objects
+    ap_list = AccessPoint.objects\
+        .prefetch_related(Prefetch(
+            'interface_set',
+            queryset=Interface.objects.select_related('ipv4__ip_type__extension').select_related('domain__extension')
+        ))
     ap_list = SortTable.sort(
         ap_list,
         request.GET.get('col'),