From 2a4bea4bbc8f0147abefbc49e01beda79a61af8b Mon Sep 17 00:00:00 2001 From: Jean-Romain Garnier Date: Fri, 24 Apr 2020 18:23:52 +0200 Subject: [PATCH] Handle object creation in event logs --- logs/models.py | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/logs/models.py b/logs/models.py index 282d60bc..3b796c84 100644 --- a/logs/models.py +++ b/logs/models.py @@ -430,17 +430,24 @@ class VersionAction(HistoryEvent): def edits(self, hide=["password", "pwd_ntlm", "gpg_fingerprint"]): self.previous_version = self._previous_version() + + if self.previous_version is None: + return None, None, None + self.edited_fields = self._compute_diff(self.version, self.previous_version) return super(VersionAction, self).edits(hide) def _previous_version(self): model = self.object_type() - return next( - filter( - lambda x: x.field_dict["id"] == self.object_id() and x.revision.date_created < self.version.revision.date_created, - Version.objects.get_for_model(model).order_by("-revision__date_created") + try: + return next( + filter( + lambda x: x.field_dict["id"] == self.object_id() and x.revision.date_created < self.version.revision.date_created, + Version.objects.get_for_model(model).order_by("-revision__date_created") + ) ) - ) + except StopIteration: + return None def _compute_diff(self, v1, v2): """